diff --git a/st.c b/st.c index 53e9dc8320..07a083abb0 100644 --- a/st.c +++ b/st.c @@ -1363,7 +1363,6 @@ st_shift(st_table *tab, st_data_t *key, st_data_t *value) return 1; } } - tab->entries_start = tab->entries_bound = 0; if (value != 0) *value = 0; return 0; } diff --git a/test/ruby/test_hash.rb b/test/ruby/test_hash.rb index 39376524fa..073a0dabe8 100644 --- a/test/ruby/test_hash.rb +++ b/test/ruby/test_hash.rb @@ -1069,6 +1069,19 @@ class TestHash < Test::Unit::TestCase assert_nil(h.shift) end + def test_shift_for_empty_hash + # [ruby-dev:51159] + h = @cls[] + 100.times{|n| + while h.size < n + k = Random.rand 0..1<<30 + h[k] = 1 + end + 0 while h.shift + assert_equal({}, h) + } + end + def test_reject_bang2 assert_equal({1=>2}, @cls[1=>2,3=>4].reject! {|k, v| k + v == 7 }) assert_nil(@cls[1=>2,3=>4].reject! {|k, v| k == 5 })