mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
Fix setting method visibility for a refinement without an origin class
If a class has been refined but does not have an origin class, there is a single method entry marked with VM_METHOD_TYPE_REFINED, but it contains the original method entry. If the original method entry is present, we shouldn't skip the method when searching even when skipping refined methods. Fixes [Bug #17519]
This commit is contained in:
parent
cb78aaeded
commit
4b36a597f4
Notes:
git
2021-04-24 08:31:39 +09:00
2 changed files with 111 additions and 2 deletions
|
@ -2294,7 +2294,7 @@ class TestModule < Test::Unit::TestCase
|
|||
assert_equal(0, 1 / 2)
|
||||
end
|
||||
|
||||
def test_visibility_after_refine_and_visibility_change
|
||||
def test_visibility_after_refine_and_visibility_change_with_origin_class
|
||||
m = Module.new
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
|
@ -2317,6 +2317,114 @@ class TestModule < Test::Unit::TestCase
|
|||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_visibility_after_multiple_refine_and_visibility_change_with_origin_class
|
||||
m = Module.new
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
end
|
||||
c.prepend(m)
|
||||
Module.new do
|
||||
refine c do
|
||||
def x; :y end
|
||||
end
|
||||
end
|
||||
Module.new do
|
||||
refine c do
|
||||
def x; :z end
|
||||
end
|
||||
end
|
||||
|
||||
o1 = c.new
|
||||
o2 = c.new
|
||||
assert_equal(:x, o1.public_send(:x))
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
o1.singleton_class.send(:private, :x)
|
||||
o2.singleton_class.send(:public, :x)
|
||||
|
||||
assert_raise(NoMethodError) { o1.public_send(:x) }
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_visibility_after_refine_and_visibility_change_without_origin_class
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
end
|
||||
Module.new do
|
||||
refine c do
|
||||
def x; :y end
|
||||
end
|
||||
end
|
||||
o1 = c.new
|
||||
o2 = c.new
|
||||
o1.singleton_class.send(:private, :x)
|
||||
o2.singleton_class.send(:public, :x)
|
||||
assert_raise(NoMethodError) { o1.public_send(:x) }
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_visibility_after_multiple_refine_and_visibility_change_without_origin_class
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
end
|
||||
Module.new do
|
||||
refine c do
|
||||
def x; :y end
|
||||
end
|
||||
end
|
||||
Module.new do
|
||||
refine c do
|
||||
def x; :z end
|
||||
end
|
||||
end
|
||||
o1 = c.new
|
||||
o2 = c.new
|
||||
o1.singleton_class.send(:private, :x)
|
||||
o2.singleton_class.send(:public, :x)
|
||||
assert_raise(NoMethodError) { o1.public_send(:x) }
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_visibility_after_refine_and_visibility_change_with_superclass
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
end
|
||||
sc = Class.new(c)
|
||||
Module.new do
|
||||
refine sc do
|
||||
def x; :y end
|
||||
end
|
||||
end
|
||||
o1 = sc.new
|
||||
o2 = sc.new
|
||||
o1.singleton_class.send(:private, :x)
|
||||
o2.singleton_class.send(:public, :x)
|
||||
assert_raise(NoMethodError) { o1.public_send(:x) }
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_visibility_after_multiple_refine_and_visibility_change_with_superclass
|
||||
c = Class.new do
|
||||
def x; :x end
|
||||
end
|
||||
sc = Class.new(c)
|
||||
Module.new do
|
||||
refine sc do
|
||||
def x; :y end
|
||||
end
|
||||
end
|
||||
Module.new do
|
||||
refine sc do
|
||||
def x; :z end
|
||||
end
|
||||
end
|
||||
o1 = sc.new
|
||||
o2 = sc.new
|
||||
o1.singleton_class.send(:private, :x)
|
||||
o2.singleton_class.send(:public, :x)
|
||||
assert_raise(NoMethodError) { o1.public_send(:x) }
|
||||
assert_equal(:x, o2.public_send(:x))
|
||||
end
|
||||
|
||||
def test_prepend_visibility
|
||||
bug8005 = '[ruby-core:53106] [Bug #8005]'
|
||||
c = Class.new do
|
||||
|
|
|
@ -977,7 +977,8 @@ search_method0(VALUE klass, ID id, VALUE *defined_class_ptr, bool skip_refined)
|
|||
for (; klass; klass = RCLASS_SUPER(klass)) {
|
||||
RB_DEBUG_COUNTER_INC(mc_search_super);
|
||||
if ((me = lookup_method_table(klass, id)) != 0) {
|
||||
if (!skip_refined || me->def->type != VM_METHOD_TYPE_REFINED) {
|
||||
if (!skip_refined || me->def->type != VM_METHOD_TYPE_REFINED ||
|
||||
me->def->body.refined.orig_me) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Reference in a new issue