From 4dc5b6ff584834396d15fa3492500b936dbc1e3d Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 18 May 2018 00:36:24 +0000 Subject: [PATCH] parse.y: relax literal in condition warnings * parse.y (cond0): do not warn literal boolean (true and false) in condition expressions, as they are often used as infinite loops, deactivated code block, etc. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63457 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- parse.y | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/parse.y b/parse.y index f044ae2aff..c2ad68e305 100644 --- a/parse.y +++ b/parse.y @@ -9823,6 +9823,10 @@ cond0(struct parser_params *p, NODE *node, int method_op, const YYLTYPE *loc) warn_unless_e_option(p, node, "regex literal in condition"); nd_set_type(node, NODE_MATCH); } + else if (node->nd_lit == Qtrue || + node->nd_lit == Qfalse) { + /* booleans are OK, e.g., while true */ + } else { if (!method_op) parser_warning(p, node, "literal in condition");