kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Revert "parse.y: Deprecate flip-flops"

Browse source 
This reverts commit bae638ad5b.

[Feature #5400]
This commit is contained in:
Nobuyoshi Nakada 2019-07-11 14:29:35 +09:00
parent d77b84ca82
commit 4e038a7e64
No known key found for this signature in database
GPG key ID: 4BC7D6DF58D8DF60
3 changed files with 2 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
parse.y
View file

@ -10930,10 +10930,8 @@ cond0(struct parser_params *p, NODE *node, int method_op, const YYLTYPE *loc)
case NODE_DOT3:
node->nd_beg = range_op(p, node->nd_beg, loc);
node->nd_end = range_op(p, node->nd_end, loc);
if (nd_type(node) == NODE_DOT2 || nd_type(node) == NODE_DOT3) {
nd_set_type(node, nd_type(node) == NODE_DOT2 ? NODE_FLIP2 : NODE_FLIP3);
parser_warn(p, node, "flip-flop is deprecated");
}
if (nd_type(node) == NODE_DOT2) nd_set_type(node,NODE_FLIP2);
else if (nd_type(node) == NODE_DOT3) nd_set_type(node, NODE_FLIP3);
if (!method_op && !e_option_supplied(p)) {
int b = literal_node(node->nd_beg);
int e = literal_node(node->nd_end);

12
spec/ruby/language/if_spec.rb
View file

@ -308,18 +308,6 @@ describe "The if expression" do
6.times(&b)
ScratchPad.recorded.should == [4, 5, 4, 5]
end
ruby_version_is "2.6" do
it 'is deprecated' do
i = 4
-> do
eval "ScratchPad << 'it works' if (i == 4)..(i == 7)"
end.should complain(/flip-flop is deprecated/)
ScratchPad.recorded.should == ['it works']
end
end
end
end

2
test/ruby/test_syntax.rb
View file

@ -1027,9 +1027,7 @@ eom
eval('1 if !//')
end
assert_warn('') do
verbose_bak, $VERBOSE = $VERBOSE, nil
eval('1 if !(true..false)')
$VERBOSE = verbose_bak
end
assert_warning('') do
eval('1 if !1')