1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[ruby/csv] Add undef: :replace for CSV.open (#129)

This PR adds `undef: :replace` option for `CSV.open`.

`File.open` has `undef: :replace` option, but `CSV.open` does not.
It would be convenient if `CSV.open` could have a shortcut by having
`undef: :replace` option.
https://github.com/ruby/csv/commit/cff8b18480
This commit is contained in:
Koichi ITO 2020-06-02 08:30:25 +09:00 committed by Nobuyoshi Nakada
parent cf8157e001
commit 4e33a87879
No known key found for this signature in database
GPG key ID: 7CD2805BFA3770C6
Notes: git 2020-07-20 03:35:41 +09:00
2 changed files with 29 additions and 0 deletions

View file

@ -960,6 +960,11 @@ class CSV
# open( filename, mode = "rb", **options )
# open( filename, **options )
#
# possible options elements:
# hash form:
# :undef => :replace # replace undefined conversion
# :replace => string # replacement string ("?" or "\uFFFD" if not specified)
#
# This method opens an IO object, and wraps that with CSV. This is intended
# as the primary interface for writing a CSV file.
#
@ -1021,6 +1026,8 @@ class CSV
# wrap a File opened with the remaining +args+ with no newline
# decorator
file_opts = {universal_newline: false}.merge(options)
options.delete(:undef)
options.delete(:replace)
begin
f = File.open(filename, mode, **file_opts)

View file

@ -125,6 +125,28 @@ class TestCSVInterfaceRead < Test::Unit::TestCase
end
end
def test_open_with_undef_replace
# U+00B7 Middle Dot
CSV.open(@input.path, "w", encoding: Encoding::CP932, undef: :replace) do |rows|
rows << ["\u00B7"]
end
CSV.open(@input.path, encoding: Encoding::CP932) do |csv|
assert_equal([["?"]],
csv.to_a)
end
end
def test_open_with_undef_replace_and_replace_string
# U+00B7 Middle Dot
CSV.open(@input.path, "w", encoding: Encoding::CP932, undef: :replace, replace: "X") do |rows|
rows << ["\u00B7"]
end
CSV.open(@input.path, encoding: Encoding::CP932) do |csv|
assert_equal([["X"]],
csv.to_a)
end
end
def test_parse
assert_equal(@rows,
CSV.parse(@data, col_sep: "\t", row_sep: "\r\n"))