diff --git a/ChangeLog b/ChangeLog index 3e702766bd..3631b3f9c4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Thu Apr 4 16:54:40 2013 Nobuyoshi Nakada + + * object.c (rb_mod_const_set): avoid inadvertent symbol creation. + (rb_obj_ivar_set): ditto. + (rb_mod_cvar_set): ditto. + Thu Apr 4 15:46:48 2013 Nobuyoshi Nakada * enum.c (enum_inject): avoid inadvertent symbol creation. diff --git a/object.c b/object.c index 72de18f7ef..a6844bab99 100644 --- a/object.c +++ b/object.c @@ -2043,13 +2043,11 @@ rb_mod_const_get(int argc, VALUE *argv, VALUE mod) static VALUE rb_mod_const_set(VALUE mod, VALUE name, VALUE value) { - ID id = rb_to_id(name); - - if (!rb_is_const_id(id)) { - rb_name_error(id, "wrong constant name %"PRIsVALUE, - QUOTE_ID(id)); + if (!SYMBOL_P(name) && !rb_is_const_name(name)) { + rb_name_error_str(name, "wrong constant name %"PRIsVALUE, + QUOTE(name)); } - rb_const_set(mod, id, value); + rb_const_set(mod, rb_to_id(name), value); return value; } @@ -2166,13 +2164,11 @@ rb_obj_ivar_get(VALUE obj, VALUE iv) static VALUE rb_obj_ivar_set(VALUE obj, VALUE iv, VALUE val) { - ID id = rb_to_id(iv); - - if (!rb_is_instance_id(id)) { - rb_name_error(id, "`%"PRIsVALUE"' is not allowed as an instance variable name", - QUOTE_ID(id)); + if (!SYMBOL_P(iv) && !rb_is_instance_name(iv)) { + rb_name_error_str(iv, "`%"PRIsVALUE"' is not allowed as an instance variable name", + QUOTE(iv)); } - return rb_ivar_set(obj, id, val); + return rb_ivar_set(obj, rb_to_id(iv), val); } /* @@ -2277,13 +2273,11 @@ rb_mod_cvar_get(VALUE obj, VALUE iv) static VALUE rb_mod_cvar_set(VALUE obj, VALUE iv, VALUE val) { - ID id = rb_to_id(iv); - - if (!rb_is_class_id(id)) { - rb_name_error(id, "`%"PRIsVALUE"' is not allowed as a class variable name", - QUOTE_ID(id)); + if (!SYMBOL_P(iv) && !rb_is_class_id(iv)) { + rb_name_error_str(iv, "`%"PRIsVALUE"' is not allowed as a class variable name", + QUOTE(iv)); } - rb_cvar_set(obj, id, val); + rb_cvar_set(obj, rb_to_id(iv), val); return val; } diff --git a/test/-ext-/symbol/test_inadvertent_creation.rb b/test/-ext-/symbol/test_inadvertent_creation.rb index 247a42cab3..4b9ab1062d 100644 --- a/test/-ext-/symbol/test_inadvertent_creation.rb +++ b/test/-ext-/symbol/test_inadvertent_creation.rb @@ -193,5 +193,26 @@ module Test_Symbol assert_raise(NoMethodError) {[1, 2].inject(name)} assert_not_send([Bug::Symbol, :interned?, name]) end + + def test_module_const_set + name = noninterned_name + mod = Module.new + assert_raise(NameError) {mod.const_set(name, true)} + assert_not_send([Bug::Symbol, :interned?, name]) + end + + def test_module_cvar_set + name = noninterned_name + mod = Module.new + assert_raise(NameError) {mod.class_variable_set(name, true)} + assert_not_send([Bug::Symbol, :interned?, name]) + end + + def test_object_ivar_set + name = noninterned_name + obj = Object.new + assert_raise(NameError) {obj.instance_variable_set(name, true)} + assert_not_send([Bug::Symbol, :interned?, name]) + end end end