mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
[ruby/irb] Stringify when a non-object is passed to PP#text
If a nested object is passed to #pp, it may be sometimes passed to the #text method as an object without being stringified. This is fixed on the Ruby main repository;433a3be86a
but it was a bug of Ripper so still needs this workaround for using irb as a gem on Ruby 3.0.0 or earlier. Co-authored-by: k0kubun <takashikkbn@gmail.com>8d13df22ee
This commit is contained in:
parent
451b456051
commit
515d6b47ad
2 changed files with 25 additions and 1 deletions
|
@ -10,7 +10,12 @@ module IRB
|
|||
out
|
||||
end
|
||||
|
||||
def text(str, width = str.length)
|
||||
def text(str, width = nil)
|
||||
unless str.is_a?(String)
|
||||
str = str.inspect
|
||||
end
|
||||
width ||= str.length
|
||||
|
||||
case str
|
||||
when /\A#</, '=', '>'
|
||||
super(Color.colorize(str, [:GREEN]), width)
|
||||
|
|
|
@ -1,6 +1,7 @@
|
|||
# frozen_string_literal: false
|
||||
require 'test/unit'
|
||||
require 'irb/color'
|
||||
require 'irb/color_printer'
|
||||
require 'rubygems'
|
||||
require 'stringio'
|
||||
|
||||
|
@ -152,6 +153,20 @@ module TestIRB
|
|||
end
|
||||
end
|
||||
|
||||
def test_color_printer
|
||||
unless ripper_lexer_scan_supported?
|
||||
skip 'Ripper::Lexer#scan is supported in Ruby 2.7+'
|
||||
end
|
||||
{
|
||||
1 => "#{BLUE}#{BOLD}1#{CLEAR}",
|
||||
Struct.new('IRBTestColorPrinter', :a).new('test') => "#{GREEN}#<struct Struct::IRBTestColorPrinter#{CLEAR} a#{GREEN}=#{CLEAR}#{RED}#{BOLD}\"#{CLEAR}#{RED}test#{CLEAR}#{RED}#{BOLD}\"#{CLEAR}#{GREEN}>#{CLEAR}",
|
||||
Ripper::Lexer.new('1').scan => "[#{GREEN}#<Ripper::Lexer::Elem:#{CLEAR} on_int@1:0 END token: #{RED}#{BOLD}\"#{CLEAR}#{RED}1#{CLEAR}#{RED}#{BOLD}\"#{CLEAR}#{GREEN}>#{CLEAR}]",
|
||||
}.each do |object, result|
|
||||
actual = with_term { IRB::ColorPrinter.pp(object, '') }
|
||||
assert_equal(result, actual, "Case: IRB::ColorPrinter.pp(#{object.inspect}, '')")
|
||||
end
|
||||
end
|
||||
|
||||
def test_inspect_colorable
|
||||
{
|
||||
1 => true,
|
||||
|
@ -184,6 +199,10 @@ module TestIRB
|
|||
Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.0')
|
||||
end
|
||||
|
||||
def ripper_lexer_scan_supported?
|
||||
Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7.0')
|
||||
end
|
||||
|
||||
def with_term
|
||||
stdout = $stdout
|
||||
io = StringIO.new
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue