From 52560a92631e7b327365383e7ce83c80fcfafc05 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Thu, 25 Aug 2022 11:07:23 -0700 Subject: [PATCH] Skip flaky mkmf tests on AppVeyor It seems like TestMkmfTryConstant started to randomly fail, maybe related to 96562a517d3373466ec306b5f821a41f4758d2a6 or 073f3b7e0ad94657c04573983affb9d66e6bff2c. Some of them seem to have failed even after retries, so it feels like there's a bug in the implementation, which leaves an unrecoverable situation. https://ci.appveyor.com/project/ruby/ruby/builds/44559958/job/7uub5bmkvy4pwwl8 https://ci.appveyor.com/project/ruby/ruby/builds/44579924/job/n81xmb2mqs6no7dm https://ci.appveyor.com/project/ruby/ruby/builds/44558471/job/s4qwymmlxmfjjd35 Until we figure out what it is, I'd like to stabilize the CI by not running it. --- test/mkmf/test_constant.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/mkmf/test_constant.rb b/test/mkmf/test_constant.rb index f6834c7f28..e12250d0a2 100644 --- a/test/mkmf/test_constant.rb +++ b/test/mkmf/test_constant.rb @@ -2,6 +2,12 @@ require_relative 'base' class TestMkmfTryConstant < TestMkmf + def setup + if ENV.key?('APPVEYOR') + omit 'This test fails too often on AppVeyor' + end + end + def test_simple assert_equal( 0, mkmf {try_constant("0")}, MKMFLOG) assert_equal( 1, mkmf {try_constant("1")}, MKMFLOG)