kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

introduce RUBY_ON_BUG envval. (#2331)

Browse source 
`rb_bug()` is called at critical bug, MRI can't run anymore.
To make debug easy, this patch introduces RUBY_ON_BUG environment
variable to specify the process which is called with pid.
[Feature #16090] [GH #2331]

  RUBY_ON_BUG='gdb -p' ruby xxx.rb

In this case, if ruby interpreter causes critical bug, and call
rb_bug(), then "gdb -p [PID]' is called by system(3). You can
debug on invoked gdb.

This feature is limited on RUBY_DEVEL build.
This commit is contained in:
Koichi Sasada 2019-08-15 13:48:58 +09:00 committed by GitHub
parent 132b7eb104
commit 53a55aeff3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: git 2019-08-31 04:40:14 +09:00 
Merged-By: ko1
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
error.c
View file

@ -429,8 +429,9 @@ bug_report_file(const char *file, int line)
if ((ssize_t)fwrite(buf, 1, len, out) == (ssize_t)len ||
(ssize_t)fwrite(buf, 1, len, (out = stdout)) == (ssize_t)len) {
return out;
return out;
}
return NULL;
}
@ -519,6 +520,17 @@ bug_report_begin_valist(FILE *out, const char *fmt, va_list args)
snprintf(buf, sizeof(buf), "\n%s\n\n", ruby_description);
fputs(buf, out);
preface_dump(out);
#if RUBY_DEVEL
const char *cmd = getenv("RUBY_ON_BUG");
if (cmd) {
snprintf(buf, sizeof(buf), "%s %d", cmd, getpid());
int r = system(buf);
if (r == -1) {
snprintf(buf, sizeof(buf), "Launching RUBY_ON_BUG command failed.");
}
}
#endif
}
#define bug_report_begin(out, fmt) do { \