kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Remove part of comment that fell out of date

Browse source 
272ac23aa8
This commit is contained in:
David Rodríguez 2022-06-14 16:47:55 +02:00 • committed by git
parent 8855b68f97
commit 5450b409fc
2 changed files with 4 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/rubygems/ext/cargo_builder.rb
View file

@ -253,14 +253,9 @@ class Gem::Ext::CargoBuilder < Gem::Ext::Builder
tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
# Some versions of `mktmpdir` return absolute paths, which will break make
# if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
# paths cause all C extension builds to fail.
# if the paths contain spaces.
#
# As such, we convert to a relative path unless we are using Ruby 1.9.x on
# Windows. This means that when using Ruby 1.9.x on Windows, paths with
# spaces do not work.
#
# Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
# As such, we convert to a relative path.
tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
full_tmp_dest = File.join(extension_dir, tmp_dest_relative)

9
lib/rubygems/ext/ext_conf_builder.rb
View file

@ -13,14 +13,9 @@ class Gem::Ext::ExtConfBuilder < Gem::Ext::Builder
tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
# Some versions of `mktmpdir` return absolute paths, which will break make
# if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
# paths cause all C extension builds to fail.
# if the paths contain spaces.
#
# As such, we convert to a relative path unless we are using Ruby 1.9.x on
# Windows. This means that when using Ruby 1.9.x on Windows, paths with
# spaces do not work.
#
# Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
# As such, we convert to a relative path.
tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
destdir = ENV["DESTDIR"]