kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Raise when loading unprovided builtin function [Bug #17192]

Browse source
This commit is contained in:
Nobuyoshi Nakada 2020-11-30 15:19:49 +09:00 committed by GitHub
parent 73a337e214
commit 555bd83a8e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: git 2020-11-30 15:20:15 +09:00 
Merged: https://github.com/ruby/ruby/pull/3622

Merged-By: nobu <nobu@ruby-lang.org>
2 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
compile.c
View file

@ -10296,14 +10296,13 @@ ibf_load_builtin(const struct ibf_load *load, ibf_offset_t *offset)
const char *name = (char *)ibf_load_ptr(load, offset, len);
if (0) {
for (int i=0; i<len; i++) fprintf(stderr, "%c", name[i]);
fprintf(stderr, "!!\n");
fprintf(stderr, "%.*s!!\n", len, name);
}
const struct rb_builtin_function *table = GET_VM()->builtin_function_table;
if (table == NULL) rb_bug("%s: table is not provided.", RUBY_FUNCTION_NAME_STRING);
if (table == NULL) rb_raise(rb_eArgError, "builtin function table is not provided");
if (strncmp(table[i].name, name, len) != 0) {
rb_bug("%s: index (%d) mismatch (expect %s but %s).", RUBY_FUNCTION_NAME_STRING, i, name, table[i].name);
rb_raise(rb_eArgError, "builtin function index (%d) mismatch (expect %s but %s)", i, name, table[i].name);
}
// fprintf(stderr, "load-builtin: name:%s(%d)\n", table[i].name, table[i].argc);

15
test/ruby/test_iseq.rb
View file

@ -590,6 +590,21 @@ class TestISeq < Test::Unit::TestCase
assert_equal([:func_ptr, :argc, :index, :name], invokebuiltin[1].keys)
end
def test_iseq_builtin_load
Tempfile.create(["builtin", ".iseq"]) do |f|
f.binmode
f.write(RubyVM::InstructionSequence.of(1.method(:abs)).to_binary)
f.close
assert_separately(["-", f.path], "#{<<~"begin;"}\n#{<<~'end;'}")
begin;
bin = File.binread(ARGV[0])
assert_raise(ArgumentError) do
RubyVM::InstructionSequence.load_from_binary(bin)
end
end;
end
end
def test_iseq_option_debug_level
assert_raise(TypeError) {ISeq.compile("", debug_level: "")}
assert_ruby_status([], "#{<<~"begin;"}\n#{<<~'end;'}")