1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[rubygems/rubygems] Improve wording of some specs

3372b21553
This commit is contained in:
David Rodríguez 2020-05-28 21:10:08 +02:00 committed by Hiroshi SHIBATA
parent ff74725dc3
commit 5989827dc7
Notes: git 2020-06-05 07:34:01 +09:00

View file

@ -157,19 +157,19 @@ RSpec.describe "bundle install with groups" do
expect(the_bundle).not_to include_gems "thin 1.0" expect(the_bundle).not_to include_gems "thin 1.0"
end end
it "does install gems from the optional group when requested" do it "installs gems from the optional group when requested" do
bundle :install, forgotten_command_line_options(:with => "debugging") bundle :install, forgotten_command_line_options(:with => "debugging")
expect(the_bundle).to include_gems "thin 1.0" expect(the_bundle).to include_gems "thin 1.0"
end end
it "does install gems from the previously requested group" do it "installs gems from the previously requested group" do
bundle :install, forgotten_command_line_options(:with => "debugging") bundle :install, forgotten_command_line_options(:with => "debugging")
expect(the_bundle).to include_gems "thin 1.0" expect(the_bundle).to include_gems "thin 1.0"
bundle :install bundle :install
expect(the_bundle).to include_gems "thin 1.0" expect(the_bundle).to include_gems "thin 1.0"
end end
it "does install gems from the optional groups requested with BUNDLE_WITH" do it "installs gems from the optional groups requested with BUNDLE_WITH" do
ENV["BUNDLE_WITH"] = "debugging" ENV["BUNDLE_WITH"] = "debugging"
bundle :install bundle :install
expect(the_bundle).to include_gems "thin 1.0" expect(the_bundle).to include_gems "thin 1.0"
@ -182,13 +182,13 @@ RSpec.describe "bundle install with groups" do
expect(the_bundle).not_to include_gems "thin 1.0" expect(the_bundle).not_to include_gems "thin 1.0"
end end
it "does remove groups from without when passed at --with", :bundler => "< 3" do it "removes groups from without when passed at --with", :bundler => "< 3" do
bundle :install, forgotten_command_line_options(:without => "emo") bundle :install, forgotten_command_line_options(:without => "emo")
bundle :install, forgotten_command_line_options(:with => "emo") bundle :install, forgotten_command_line_options(:with => "emo")
expect(the_bundle).to include_gems "activesupport 2.3.5" expect(the_bundle).to include_gems "activesupport 2.3.5"
end end
it "does remove groups from with when passed at --without", :bundler => "< 3" do it "removes groups from with when passed at --without", :bundler => "< 3" do
bundle :install, forgotten_command_line_options(:with => "debugging") bundle :install, forgotten_command_line_options(:with => "debugging")
bundle :install, forgotten_command_line_options(:without => "debugging") bundle :install, forgotten_command_line_options(:without => "debugging")
expect(the_bundle).not_to include_gem "thin 1.0" expect(the_bundle).not_to include_gem "thin 1.0"
@ -219,12 +219,12 @@ RSpec.describe "bundle install with groups" do
expect(the_bundle).not_to include_gems "activesupport 2.3.5" expect(the_bundle).not_to include_gems "activesupport 2.3.5"
end end
it "does have no effect when listing a not optional group in with" do it "has no effect when listing a not optional group in with" do
bundle :install, forgotten_command_line_options(:with => "emo") bundle :install, forgotten_command_line_options(:with => "emo")
expect(the_bundle).to include_gems "activesupport 2.3.5" expect(the_bundle).to include_gems "activesupport 2.3.5"
end end
it "does have no effect when listing an optional group in without" do it "has no effect when listing an optional group in without" do
bundle :install, forgotten_command_line_options(:without => "debugging") bundle :install, forgotten_command_line_options(:without => "debugging")
expect(the_bundle).not_to include_gems "thin 1.0" expect(the_bundle).not_to include_gems "thin 1.0"
end end