kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

fix random EBADF problem

Browse source 
```ruby
      r, w = IO.pipe
      r.close

      IO.for_fd(w.fileno).close
```

This code closes a file descriptor `w.fileno`, but `w` doesn't know
the closing. Another code can open same file descriptor with opening
file (`f`). After that, the `w` will GCed and `w.fileno` is closed
again, and `f.fileno` is closed too, so IO operations for `f` (`f.close`)
will cause EBADF.

To fix this issue, do this test in another process.
This commit is contained in:
Koichi Sasada 2021-10-26 11:35:57 +09:00
parent 7d4c59203f
commit 5c2b644166
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
test/-ext-/wait/test_wait.rb
View file

@ -12,14 +12,18 @@ class TestWait < Test::Unit::TestCase
end
def test_wait_for_invalid_fd
r, w = IO.pipe
r.close
assert_separately [], <<~'RUBY'
require '-test-/wait'
IO.for_fd(w.fileno).close
r, w = IO.pipe
r.close
assert_raise(Errno::EBADF) do
IO.io_wait(w, IO::WRITABLE, nil)
end
IO.for_fd(w.fileno).close
assert_raise(Errno::EBADF) do
IO.io_wait(w, IO::WRITABLE, nil)
end
RUBY
end
def test_wait_for_closed_pipe