kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

RubyVM::MJIT.pause(wait: true) should wait

Browse source 
for all compilations and compaction.

Prior to this commit, the last-compiled code has not been used because
MJIT worker is stopped before setting the code, and compaction has also
been skipped.

But it was not intentional and `wait: true` pause should wait until
those two things by its feature.
This commit is contained in:
Takashi Kokubun 2019-09-26 12:53:41 +09:00
parent 47a234954a
commit 5d8f112505
No known key found for this signature in database
GPG key ID: 6FFC433B12EE23DD
4 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
test/ruby/test_rubyvm_mjit.rb
View file

@ -35,6 +35,22 @@ class TestRubyVMMJIT < Test::Unit::TestCase
)
end
def test_pause_waits_until_compaction
out, err = eval_with_jit(<<~'EOS', verbose: 1, min_calls: 1, wait: false)
def a() end; a
def b() end; b
RubyVM::MJIT.pause
EOS
assert_equal(
2, err.scan(/#{JITSupport::JIT_SUCCESS_PREFIX}/).size,
"unexpected stdout:\n```\n#{out}```\n\nstderr:\n```\n#{err}```",
)
assert_equal(
1, err.scan(/#{JITSupport::JIT_COMPACTION_PREFIX}/).size,
"unexpected stdout:\n```\n#{out}```\n\nstderr:\n```\n#{err}```",
) unless RUBY_PLATFORM.match?(/mswin|mingw/) # compaction is not supported on Windows yet
end
def test_pause_does_not_hang_on_full_units
out, _ = eval_with_jit(<<~'EOS', verbose: 1, min_calls: 1, max_cache: 10, wait: false)
i = 0