kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

rss itunes: fix a bug that <itunes:explicit> value isn't fully supported

Browse source 
Fix GH-1725

<itunes:explicit> accepts "explicit", "yes", "true", "clean", "no" and
"false" as valid values.

Here is the <itunes:explicit>'s description in
https://help.apple.com/itc/podcasts_connect/#/itcb54353390:

> The <itunes:explicit> tag indicates whether your podcast contains
> explicit material. You can specify the following values:
>
>   * Yes | Explicit | True. If you specify yes, explicit, or true,
>     indicating the presence of explicit content, the iTunes Store
>     displays an Explicit parental advisory graphic for your podcast.
>
>   * Clean | No | False. If you specify clean, no, or false, indicating
>     that none of your podcast episodes contain explicit language or
>     adult content, the iTunes Store displays a Clean parental
>     advisory graphic for your podcast.

I don't know whether <itunes:explicit> value is case sensitive or
insensitive. But the current implementation is case insensitive.

Reported by Valerie Woolard Srinivasan. Thanks!!!


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
kou 2017-10-22 16:03:57 +00:00
parent 588ac3ee1f
commit 5e64882123
6 changed files with 32 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

14
test/rss/test_maker_itunes.rb
View file

@ -279,10 +279,20 @@ module RSS
def assert_maker_itunes_explicit(maker_readers, feed_readers=nil)
_wrap_assertion do
feed_readers ||= maker_readers
_assert_maker_itunes_explicit(true, "yes", maker_readers, feed_readers)
_assert_maker_itunes_explicit(true, "explicit",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(true, "yes",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(true, "true",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(false, "clean",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(nil, "no", maker_readers, feed_readers)
_assert_maker_itunes_explicit(false, "no",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(false, "false",
maker_readers, feed_readers)
_assert_maker_itunes_explicit(nil, "invalid",
maker_readers, feed_readers)
end
end