mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
Enable rubocop-performance StartWith cop
- this would keep the could-be-a-string-method matches few
This commit is contained in:
parent
f8f5e7fadf
commit
5eacf4e72c
Notes:
git
2020-06-05 07:33:38 +09:00
5 changed files with 7 additions and 9 deletions
|
@ -456,9 +456,7 @@ class Gem::Command
|
|||
until extra.empty? do
|
||||
ex = []
|
||||
ex << extra.shift
|
||||
if (!extra.first.to_s.empty? && !extra.first.to_s.start_with?("-"))
|
||||
ex << extra.shift
|
||||
end
|
||||
ex << extra.shift if extra.first.to_s =~ /^[^-]/ # rubocop:disable Performance/StartWith
|
||||
result << ex if handles?(ex)
|
||||
end
|
||||
|
||||
|
|
|
@ -584,9 +584,9 @@ class Gem::Installer
|
|||
def shebang(bin_file_name)
|
||||
ruby_name = RbConfig::CONFIG['ruby_install_name'] if @env_shebang
|
||||
path = File.join gem_dir, spec.bindir, bin_file_name
|
||||
first_line = File.open(path, "rb") {|file| file.gets}
|
||||
first_line = File.open(path, "rb") {|file| file.gets} || ""
|
||||
|
||||
if /\A#!/ =~ first_line
|
||||
if first_line.start_with?("#!")
|
||||
# Preserve extra words on shebang line, like "-w". Thanks RPA.
|
||||
shebang = first_line.sub(/\A\#!.*?ruby\S*((\s+\S+)+)/, "#!#{Gem.ruby}")
|
||||
opts = $1
|
||||
|
|
|
@ -150,7 +150,7 @@ class Gem::Platform
|
|||
|
||||
# cpu
|
||||
([nil,'universal'].include?(@cpu) or [nil, 'universal'].include?(other.cpu) or @cpu == other.cpu or
|
||||
(@cpu == 'arm' and other.cpu =~ /\Aarm/)) and
|
||||
(@cpu == 'arm' and other.cpu.start_with?("arm"))) and
|
||||
|
||||
# os
|
||||
@os == other.os and
|
||||
|
|
|
@ -109,7 +109,7 @@ class Gem::Security::Signer
|
|||
subject_alt_name = cert.extensions.find { |e| 'subjectAltName' == e.oid }
|
||||
|
||||
if subject_alt_name
|
||||
/\Aemail:/ =~ subject_alt_name.value
|
||||
/\Aemail:/ =~ subject_alt_name.value # rubocop:disable Performance/StartWith
|
||||
|
||||
$' || subject_alt_name.value
|
||||
else
|
||||
|
|
|
@ -1151,7 +1151,7 @@ class Gem::Specification < Gem::BasicSpecification
|
|||
|
||||
def self.normalize_yaml_input(input)
|
||||
result = input.respond_to?(:read) ? input.read : input
|
||||
result = "--- " + result unless result =~ /\A--- /
|
||||
result = "--- " + result unless result.start_with?("--- ")
|
||||
result = result.dup
|
||||
result.gsub!(/ !!null \n/, " \n")
|
||||
# date: 2011-04-26 00:00:00.000000000Z
|
||||
|
@ -2104,7 +2104,7 @@ class Gem::Specification < Gem::BasicSpecification
|
|||
end
|
||||
|
||||
if @specification_version > CURRENT_SPECIFICATION_VERSION and
|
||||
sym.to_s.end_with?("=")
|
||||
sym.to_s.end_with?("=")
|
||||
warn "ignoring #{sym} loading #{full_name}" if $DEBUG
|
||||
else
|
||||
super
|
||||
|
|
Loading…
Reference in a new issue