kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] Remove misleading comments

Browse source 
`site_dir`, or `vendor_dir`, is the location where the default version
of bundler & rubygems gets installed. These folders are placed directly
in the LOAD_PATH, so they cannot hold any nested gem directory
structure. So a single copy of either rubygems or bundler can be placed
in these folders.

What the tests are actually testing is the TODO comment that I'm
removing: that installing the default copy of bundler doesn't affect any
already installed copies of bundler as regular gems.

https://github.com/rubygems/rubygems/commit/7ca8831d72
This commit is contained in:
David Rodríguez 2019-12-21 19:55:20 +01:00 committed by Hiroshi SHIBATA
parent 373d01bb7d
commit 6438c5848d
Notes: git 2020-05-08 14:14:21 +09:00 
Merged: https://github.com/ruby/ruby/pull/3092
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
test/rubygems/test_gem_commands_setup_command.rb
View file

@ -254,15 +254,8 @@ class TestGemCommandsSetupCommand < Gem::TestCase
# expect to remove normal gem that was same version. because it's promoted default gems.
refute_path_exists File.join(Gem.default_dir, "specifications", "bundler-#{BUNDLER_VERS}.gemspec")
# expect to install default gems. It location was `site_ruby` directory on real world.
assert_path_exists "default/gems/bundler-#{BUNDLER_VERS}"
# expect to not remove other versions of bundler on `site_ruby`
assert_path_exists 'default/gems/bundler-1.15.4'
# TODO: We need to assert to remove same version of bundler on gem_dir directory(It's not site_ruby dir)
# expect to not remove bundler-* directory.
assert_path_exists 'default/gems/bundler-audit-1.0.0'
end