kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

merge revision(s) 57236: [Backport #13089]

Browse source 
rational.c: memory leak in gcd

	* rational.c (rb_gcd_gmp): fix memory leak.  patched by KISHIMOTO,
	  Makoto <ksmakoto AT dd.iij4u.or.jp> in [ruby-dev:49934].
	  [Bug #13089]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@58173 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nagachika 2017-03-27 16:17:42 +00:00
parent 7b509a5c0c
commit 648ee72d18
3 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
rational.c
View file

@ -286,10 +286,15 @@ rb_gcd_gmp(VALUE x, VALUE y)
mpz_gcd(mz, mx, my);
mpz_clear(mx);
mpz_clear(my);
zn = (mpz_sizeinbase(mz, 16) + SIZEOF_BDIGIT*2 - 1) / (SIZEOF_BDIGIT*2);
z = rb_big_new(zn, 1);
mpz_export(BIGNUM_DIGITS(z), &count, -1, sizeof(BDIGIT), 0, nails, mz);
mpz_clear(mz);
return rb_big_norm(z);
}
#endif

10
test/ruby/test_rational.rb
View file

@ -870,6 +870,16 @@ class Rational_Test < Test::Unit::TestCase
assert_equal(1152921470247108503, 1073741789.lcm(1073741827))
end
def test_gcd_no_memory_leak
assert_no_memory_leak([], "#{<<-"begin;"}", "#{<<-"end;"}", limit: 1.2, rss: true)
x = (1<<121) + 1
y = (1<<99) + 1
1000.times{x.gcd(y)}
begin;
100.times {1000.times{x.gcd(y)}}
end;
end
def test_supp
assert_equal(true, 1.real?)
assert_equal(true, 1.1.real?)

2
version.h
View file

@ -1,6 +1,6 @@
#define RUBY_VERSION "2.3.3"
#define RUBY_RELEASE_DATE "2017-03-28"
#define RUBY_PATCHLEVEL 282
#define RUBY_PATCHLEVEL 283
#define RUBY_RELEASE_YEAR 2017
#define RUBY_RELEASE_MONTH 3