kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

uJIT: Add exit counters for leave and refactor stats printout code

Browse source 
Filter out counters that are zero and make it easier to have multiple
printout groups.

On `railsbench`:

```
opt_send_without_block exit reasons:
    se_finish_frame     184809 (100.0%)
```
This commit is contained in:
Alan Wu 2021-03-03 17:31:20 -05:00
parent 8a9ee00a31
commit 699bf97493
3 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ujit.rb
View file

@ -53,10 +53,16 @@ module UJIT
return unless counters
$stderr.puts("***uJIT: Printing runtime counters from ujit.rb***")
$stderr.puts("opt_send_without_block exit reasons: ")
counters.filter! { |key, _| key.start_with?('oswb_') }
counters.transform_keys! { |key| key.to_s.delete_prefix('oswb_') }
print_counters(counters, prefix: 'oswb_', prompt: 'opt_send_without_block exit reasons: ')
print_counters(counters, prefix: 'leave_', prompt: 'leave exit reasons: ')
end
def print_counters(counters, prefix:, prompt:)
$stderr.puts(prompt)
counters = counters.filter { |key, _| key.start_with?(prefix) }
counters.filter! { |_, value| value > 0 }
counters.transform_keys! { |key| key.to_s.delete_prefix(prefix) }
counters = counters.to_a
counters.sort_by! { |(_, counter_value)| counter_value }

6
ujit_codegen.c
View file

@ -1644,10 +1644,10 @@ gen_leave(jitstate_t* jit, ctx_t* ctx)
// if (flags & VM_FRAME_FLAG_FINISH) != 0
x86opnd_t flags_opnd = mem_opnd(64, REG0, sizeof(VALUE) * VM_ENV_DATA_INDEX_FLAGS);
test(cb, flags_opnd, imm_opnd(VM_FRAME_FLAG_FINISH));
jnz_ptr(cb, side_exit);
jnz_ptr(cb, COUNTED_EXIT(side_exit, leave_se_finish_frame));
// Check for interrupts
ujit_check_ints(cb, side_exit);
ujit_check_ints(cb, COUNTED_EXIT(side_exit, leave_se_interrupt));
// Load the return value
mov(cb, REG0, ctx_stack_pop(ctx, 1));
@ -1664,7 +1664,7 @@ gen_leave(jitstate_t* jit, ctx_t* ctx)
// The SP points one above the topmost value
add(cb, member_opnd(REG_CFP, rb_control_frame_t, sp), imm_opnd(SIZEOF_VALUE));
mov(cb, REG_SP, member_opnd(REG_CFP, rb_control_frame_t, sp));
mov(cb, mem_opnd(64, REG_SP, -SIZEOF_VALUE), REG0);
mov(cb, mem_opnd(64, REG_SP, -SIZEOF_VALUE), REG0);
// If the return address is NULL, fall back to the interpreter
int FALLBACK_LABEL = cb_new_label(cb, "FALLBACK");

3
ujit_iface.h
View file

@ -55,6 +55,9 @@ UJIT_DECLARE_COUNTERS(
oswb_se_cc_klass_differ,
oswb_se_protected_check_failed,
leave_se_finish_frame,
leave_se_interrupt,
// Member with known name for iterating over counters
last_member
)