kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Omit a DRb test on MinGW

Browse source 
This test seems to leak a thread and let TestIOWait fail:
https://github.com/ruby/ruby/actions/runs/3065426880/jobs/4949517274

DRb almost never seemed to stably work on MinGW. I don't think we intend
to fix it either. We should just omit DRb tests when they fail on MinGW.
This commit is contained in:
Takashi Kokubun 2022-09-16 17:03:18 +09:00
parent c8d94d2797
commit 6ad6994457
No known key found for this signature in database
GPG key ID: 6FFC433B12EE23DD
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/drb/test_drb.rb
View file

@ -335,6 +335,7 @@ end
class TestDRbTCP < Test::Unit::TestCase class TestDRbTCP < Test::Unit::TestCase
def test_immediate_close def test_immediate_close
omit 'MinGW leaks a thread in this test' if /mingw/ =~ RUBY_PLATFORM
server = DRb::DRbServer.new('druby://localhost:0') server = DRb::DRbServer.new('druby://localhost:0')
host, port, = DRb::DRbTCPSocket.send(:parse_uri, server.uri) host, port, = DRb::DRbTCPSocket.send(:parse_uri, server.uri)
socket = TCPSocket.open host, port socket = TCPSocket.open host, port
@ -345,8 +346,8 @@ class TestDRbTCP < Test::Unit::TestCase
ensure ensure
client&.close client&.close
socket&.close socket&.close
server.stop_service server&.stop_service
server.thread.join server&.thread&.join
DRb::DRbConn.stop_pool DRb::DRbConn.stop_pool
end end
end end