kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Try harder to make objects move

Browse source 
Sometimes the objects we allocated may not get compacted.  This change
is to increase the likelyhood that they will move

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@67623 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
tenderlove 2019-04-20 01:59:34 +00:00
parent db14ceae42
commit 6c4fd432d0
1 changed files with 42 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
test/ruby/test_gc_compact.rb
View file

@ -14,12 +14,16 @@ class TestGCCompact < Test::Unit::TestCase
list.count - same_count list.count - same_count
end end
def big_list def big_list(level = 10)
1000.times.map { if level > 0
# try to make some empty slots by allocating an object and discarding big_list(level - 1)
Object.new else
Object.new 1000.times.map {
} # likely next to each other # try to make some empty slots by allocating an object and discarding
Object.new
Object.new
} # likely next to each other
end
end end
# Find an object that's allocated in a slot that had a previous # Find an object that's allocated in a slot that had a previous
@ -37,31 +41,39 @@ class TestGCCompact < Test::Unit::TestCase
new_object new_object
end end
def try_to_move_objects
10.times do
list_of_objects = big_list
ids = list_of_objects.map(&:object_id) # store id in map
addresses = list_of_objects.map(&self.:memory_location)
assert_equal ids, addresses
# All object ids should be equal
assert_equal 0, assert_object_ids(list_of_objects) # should be 0
GC.verify_compaction_references
# Some should have moved
id_count = assert_object_ids(list_of_objects)
skip "couldn't get objects to move" if id_count == 0
assert_operator id_count, :>, 0
new_ids = list_of_objects.map(&:object_id)
# Object ids should not change after compaction
assert_equal ids, new_ids
new_tenant = find_object_in_recycled_slot(addresses)
return [list_of_objects, addresses, new_tenant] if new_tenant
end
flunk "Couldn't get objects to move"
end
def test_find_collided_object def test_find_collided_object
list_of_objects = big_list list_of_objects, addresses, new_tenant = try_to_move_objects
ids = list_of_objects.map(&:object_id) # store id in map
addresses = list_of_objects.map(&self.:memory_location)
assert_equal ids, addresses
# All object ids should be equal
assert_equal 0, assert_object_ids(list_of_objects) # should be 0
GC.verify_compaction_references
# Some should have moved
id_count = assert_object_ids(list_of_objects)
skip "couldn't get objects to move" if id_count == 0
assert_operator id_count, :>, 0
new_ids = list_of_objects.map(&:object_id)
# Object ids should not change after compaction
assert_equal ids, new_ids
new_tenant = find_object_in_recycled_slot(addresses)
assert new_tenant
# This is the object that used to be in new_object's position # This is the object that used to be in new_object's position
previous_tenant = list_of_objects[addresses.index(memory_location(new_tenant))] previous_tenant = list_of_objects[addresses.index(memory_location(new_tenant))]