kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[ruby/fileutils] Fix mkdir_p hanging on Windows when trying to create a file on a offline drive

Browse source 
9cc6a082d7
This commit is contained in:
David Rodríguez 2022-08-01 20:35:37 +02:00 • committed by git
parent 9f3140a42e
commit 70f69f8539
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/fileutils.rb
View file

@ -374,7 +374,7 @@ module FileUtils
path = remove_trailing_slash(item)
stack = []
until File.directory?(path)
until File.directory?(path) || File.dirname(path) == path
stack.push path
path = File.dirname(path)
end

8
test/fileutils/test_fileutils.rb
View file

@ -1098,6 +1098,14 @@ class TestFileUtils < Test::Unit::TestCase
ensure
Dir.rmdir(drive) if drive and File.directory?(drive)
end
def test_mkdir_p_offline_drive
offline_drive = ("A".."Z").to_a.reverse.find {|d| !File.exist?("#{d}:/") }
assert_raise(Errno::ENOENT) {
mkdir_p "#{offline_drive}:/new_dir"
}
end
end
def test_mkdir_p_file_perm