kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Separate RDoc::TokenStream#add_tokens and #add_token

Browse source 
The old version of `add_tokens` accepts an array of tokens, and
multiple arguments of tokens by using `Array#flatten`.
And `add_token` was an alias to `add_tokens`.

I think it is unnecessarily flexible; in fact, all callsites of
`add_tokens` (except test) passes only an array of tokens.
And the code created a lot of temporal arrays.

This change makes `add_tokens` accept only one array of tokens,
and does `add_token` accept one token.  It is a bit faster (about
1 second in Ruby's `make rdoc`), and it ls also cleaner in my point of
view.
This commit is contained in:
Yusuke Endoh 2019-08-07 02:32:03 +09:00 committed by aycabta
parent 0a0760aa63
commit 723a37d038
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/rdoc/token_stream.rb
View file

@ -74,11 +74,16 @@ module RDoc::TokenStream
##
# Adds +tokens+ to the collected tokens
def add_tokens(*tokens)
tokens.flatten.each { |token| @token_stream << token }
def add_tokens(tokens)
@token_stream.concat(tokens)
end
alias add_token add_tokens
##
# Adds one +token+ to the collected tokens
def add_token(token)
@token_stream.push(token)
end
##
# Starts collecting tokens

4
test/rdoc/test_rdoc_any_method.rb
View file

@ -78,7 +78,7 @@ method(a, b) { |c, d| ... }
]
@c2_a.collect_tokens
@c2_a.add_tokens(*tokens)
@c2_a.add_tokens(tokens)
expected = '<span class="ruby-constant">CONSTANT</span>'
@ -96,7 +96,7 @@ method(a, b) { |c, d| ... }
]
@c2_a.collect_tokens
@c2_a.add_tokens(*tokens)
@c2_a.add_tokens(tokens)
assert_equal <<-EXPECTED.chomp, @c2_a.markup_code
<span class="ruby-comment"># File xref_data.rb, line 1</span>