1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00

[rubygems/rubygems] Fix suggestions flag

https://github.com/rubygems/rubygems/commit/b55a1393ca
This commit is contained in:
ximenasandoval 2022-01-04 17:16:40 -07:00 committed by git
parent cea4a81056
commit 73be7a85cd
2 changed files with 10 additions and 5 deletions

View file

@ -8,7 +8,12 @@ class Gem::Commands::FetchCommand < Gem::Command
include Gem::VersionOption
def initialize
super 'fetch', 'Download a gem and place it in the current directory'
defaults = {
:suggest_alternate => true,
:version => Gem::Requirement.default,
}
super 'fetch', 'Download a gem and place it in the current directory', defaults
add_bulk_threshold_option
add_proxy_option
@ -20,7 +25,7 @@ class Gem::Commands::FetchCommand < Gem::Command
add_prerelease_option
add_option '--[no-]suggestions', 'Suggest alternates when gems are not found' do |value, options|
options[:suggest_alternate] = true
options[:suggest_alternate] = value
end
end
@ -47,7 +52,7 @@ then repackaging it.
end
def check_version # :nodoc:
if options[:version] and options[:version] != Gem::Requirement.default and
if options[:version] != Gem::Requirement.default and
get_all_gem_names.size > 1
alert_error "Can't use --version with multiple gems. You can specify multiple gems with" \
" version requirements using `gem fetch 'my_gem:1.0.0' 'my_other_gem:~>2.0.0'`"
@ -66,7 +71,7 @@ then repackaging it.
gem_version ||= version
dep = Gem::Dependency.new gem_name, gem_version
dep.prerelease = options[:prerelease]
suppress_suggestions = options[:suggest_alternate]
suppress_suggestions = !options[:suggest_alternate]
specs_and_sources, errors =
Gem::SpecFetcher.fetcher.spec_for_dependency dep

View file

@ -242,7 +242,7 @@ ERROR: Possible alternatives: foo
end
@cmd.options[:args] = %w[foo:2]
@cmd.options[:suggest_alternate] = true
@cmd.options[:suggest_alternate] = false
use_ui @ui do
@cmd.execute