kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* lib/rexml/parsers/treeparser.rb (REXML::Parsers::TreeParser#parse):

Browse source 
Add source information to parse exception on no close tag error.
  [Bug #8844]  [ruby-dev:47672]
  Patch by Ippei Obayashi. Thanks!!!
* test/rexml/parser/test_tree.rb: Add a test for the above case.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@42815 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
kou 2013-09-03 14:01:20 +00:00
parent 4c1fa1a6a4
commit 73c57761a9
3 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
Tue Sep 3 22:59:58 2013 Kouhei Sutou <kou@cozmixng.org>
* lib/rexml/parsers/treeparser.rb (REXML::Parsers::TreeParser#parse):
Add source information to parse exception on no close tag error.
[Bug #8844] [ruby-dev:47672]
Patch by Ippei Obayashi. Thanks!!!
* test/rexml/parser/test_tree.rb: Add a test for the above case.
Tue Sep 3 22:57:57 2013 Kouhei Sutou <kou@cozmixng.org>
* test/rexml/parser/test_tree.rb: Fix test name to describe test

4
lib/rexml/parsers/treeparser.rb
View file

@ -24,8 +24,8 @@ module REXML
case event[0]
when :end_document
unless tag_stack.empty?
#raise ParseException.new("No close tag for #{tag_stack.inspect}")
raise ParseException.new("No close tag for #{@build_context.xpath}")
raise ParseException.new("No close tag for #{@build_context.xpath}",
@parser.source, @parser)
end
return
when :start_element

13
test/rexml/parser/test_tree.rb
View file

@ -17,6 +17,19 @@ Last 80 unconsumed characters:
MESSAGE
end
def test_no_close_tag
xml = "<root>"
exception = assert_raise(REXML::ParseException) do
parse(xml)
end
assert_equal(<<-MESSAGE, exception.to_s)
No close tag for /root
Line: 1
Position: #{xml.bytesize}
Last 80 unconsumed characters:
MESSAGE
end
private
def parse(xml)
document = REXML::Document.new