kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

parse.y: no named capture conflict warnings

Browse source 
* parse.y (reg_named_capture_assign_iter): remove named capture
  conflict warnings.  it is just annoying rather than useful.
  [ruby-core:75416] [Bug #12359]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
nobu 2016-06-13 11:50:09 +00:00
parent 9042cf217e
commit 75a68057c7
3 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ChangeLog
View file

@ -1,3 +1,9 @@
Mon Jun 13 20:50:07 2016 Nobuyoshi Nakada <nobu@ruby-lang.org>
* parse.y (reg_named_capture_assign_iter): remove named capture
conflict warnings. it is just annoying rather than useful.
[ruby-core:75416] [Bug #12359]
Mon Jun 13 20:04:00 2016 Kenta Murata <mrkn@mrkn.jp> Mon Jun 13 20:04:00 2016 Kenta Murata <mrkn@mrkn.jp>
* numeric.c (rb_int_digits, rb_fix_digits, rb_int_digits_bigbase): * numeric.c (rb_int_digits, rb_fix_digits, rb_int_digits_bigbase):

4
parse.y
View file

@ -10616,10 +10616,6 @@ reg_named_capture_assign_iter(const OnigUChar *name, const OnigUChar *name_end,
return ST_CONTINUE; return ST_CONTINUE;
} }
var = intern_cstr(s, len, enc); var = intern_cstr(s, len, enc);
if (dvar_defined(var) || local_id(var)) {
rb_warning1("named capture conflicts a local variable - %"PRIsWARN,
rb_id2str(var));
}
node = newline_node(node_assign(assignable(var, 0), NEW_LIT(ID2SYM(var)))); node = newline_node(node_assign(assignable(var, 0), NEW_LIT(ID2SYM(var))));
succ = arg->succ_block; succ = arg->succ_block;
if (!succ) succ = NEW_BEGIN(0); if (!succ) succ = NEW_BEGIN(0);

4
test/ruby/test_parse.rb
View file

@ -869,9 +869,9 @@ x = __ENCODING__
def test_named_capture_conflict def test_named_capture_conflict
a = 1 a = 1
assert_warning(/named capture conflict/) {eval("a = 1; /(?<a>)/ =~ ''")} assert_warning('') {eval("a = 1; /(?<a>)/ =~ ''")}
a = "\u{3042}" a = "\u{3042}"
assert_warning(/#{a}/) {eval("#{a} = 1; /(?<#{a}>)/ =~ ''")} assert_warning('') {eval("#{a} = 1; /(?<#{a}>)/ =~ ''")}
end end
=begin =begin