diff --git a/ChangeLog b/ChangeLog index 3a6d71f98d..a3497c3822 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Thu Jul 10 12:09:21 2008 Nobuyoshi Nakada + + * thread.c (rb_thread_wait_for): wait until timed out only when + sleeping with timeout. + Wed Jul 9 22:41:16 2008 Nobuyoshi Nakada * thread.c (sleep_timeval): wait until timed out. [ruby-core:17270] diff --git a/thread.c b/thread.c index 50748a8e14..3bee915cfb 100644 --- a/thread.c +++ b/thread.c @@ -736,29 +736,7 @@ getclockofday(struct timeval *tp) static void sleep_timeval(rb_thread_t *th, struct timeval tv) { - struct timeval to, tvn; - - getclockofday(&to); - to.tv_sec += tv.tv_sec; - if ((to.tv_usec += tv.tv_usec) >= 1000000) { - to.tv_sec++; - to.tv_usec -= 1000000; - } - - for (;;) { - native_sleep(th, &tv, 0); - getclockofday(&tvn); - if (to.tv_sec < tvn.tv_sec) break; - if (to.tv_sec == tvn.tv_sec && to.tv_usec <= tvn.tv_usec) break; - thread_debug("sleep_timeval: %ld.%.6ld > %ld.%.6ld\n", - (long)to.tv_sec, to.tv_usec, - (long)tvn.tv_sec, tvn.tv_usec); - tv.tv_sec = to.tv_sec - tvn.tv_sec; - if ((tv.tv_usec = to.tv_usec - tvn.tv_usec) < 0) { - --tv.tv_sec; - tv.tv_usec += 1000000; - } - } + native_sleep(th, &tv, 0); } void @@ -811,7 +789,29 @@ void rb_thread_wait_for(struct timeval time) { rb_thread_t *th = GET_THREAD(); - sleep_timeval(th, time); + struct timeval to, tvn; + + getclockofday(&to); + to.tv_sec += tv.tv_sec; + if ((to.tv_usec += tv.tv_usec) >= 1000000) { + to.tv_sec++; + to.tv_usec -= 1000000; + } + + for (;;) { + sleep_timeval(th, time); + getclockofday(&tvn); + if (to.tv_sec < tvn.tv_sec) break; + if (to.tv_sec == tvn.tv_sec && to.tv_usec <= tvn.tv_usec) break; + thread_debug("sleep_timeval: %ld.%.6ld > %ld.%.6ld\n", + (long)to.tv_sec, to.tv_usec, + (long)tvn.tv_sec, tvn.tv_usec); + tv.tv_sec = to.tv_sec - tvn.tv_sec; + if ((tv.tv_usec = to.tv_usec - tvn.tv_usec) < 0) { + --tv.tv_sec; + tv.tv_usec += 1000000; + } + } } void