From 7b0b9df60ec0fff1463b235779ad48cb8897956a Mon Sep 17 00:00:00 2001 From: nobu Date: Fri, 3 Dec 2010 13:36:49 +0000 Subject: [PATCH] * vm_insnhelper.c (vm_call_method): protected methods should be checked against the real class. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@30071 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ test/ruby/test_method.rb | 2 ++ vm_insnhelper.c | 8 +------- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 236fe4c48f..9fad07f19e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Fri Dec 3 22:36:45 2010 Nobuyoshi Nakada + + * vm_insnhelper.c (vm_call_method): protected methods should be + checked against the real class. + Fri Dec 3 20:23:31 2010 Nobuyoshi Nakada * lib/mkmf.rb (convertible_int): define printf format prefix too. diff --git a/test/ruby/test_method.rb b/test/ruby/test_method.rb index 2f3ba3ebd6..e5177d6217 100644 --- a/test/ruby/test_method.rb +++ b/test/ruby/test_method.rb @@ -420,6 +420,8 @@ class TestMethod < Test::Unit::TestCase end def test a = dup + a.extend(Module.new) + a.extend(Module.new) class << a protected :meth end diff --git a/vm_insnhelper.c b/vm_insnhelper.c index 6ec6026e37..cc01cdf7ef 100644 --- a/vm_insnhelper.c +++ b/vm_insnhelper.c @@ -629,13 +629,7 @@ vm_call_method(rb_thread_t *th, rb_control_frame_t *cfp, else if (!(flag & VM_CALL_OPT_SEND_BIT) && (me->flag & NOEX_MASK) & NOEX_PROTECTED) { VALUE defined_class = me->klass; - if (FL_TEST(defined_class, FL_SINGLETON)) { - defined_class = RCLASS_SUPER(defined_class); - } - else if (RB_TYPE_P(defined_class, T_ICLASS)) { - defined_class = RBASIC(defined_class)->klass; - } - + defined_class = rb_class_real(defined_class); if (!rb_obj_is_kind_of(cfp->self, defined_class)) { val = vm_method_missing(th, id, recv, num, blockptr, NOEX_PROTECTED); }