kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

feature_option: do not goto into a branch

Browse source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-16 15:32:39 +09:00
parent 689dd3aecb
commit 7cf4625690
Notes: git 2020-06-29 11:06:51 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ruby.c
View file

@ -911,9 +911,7 @@ feature_option(const char *str, int len, void *arg, const unsigned int enable)
if (NAME_MATCH_P(#bit, str, len)) {set |= mask = FEATURE_BIT(bit); FEATURE_FOUND;}
EACH_FEATURES(SET_FEATURE, ;);
if (NAME_MATCH_P("all", str, len)) {
found:
FEATURE_SET_TO(*argp, mask, (mask & enable));
return;
goto found;
}
#if AMBIGUOUS_FEATURE_NAMES
if (matched == 1) goto found;
@ -933,6 +931,11 @@ feature_option(const char *str, int len, void *arg, const unsigned int enable)
rb_warn("unknown argument for --%s: `%.*s'",
enable ? "enable" : "disable", len, str);
rb_warn("features are [%.*s].", (int)strlen(list), list);
return;
found:
FEATURE_SET_TO(*argp, mask, (mask & enable));
return;
}
static void