kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

* ext/zlib/zlib.c (rb_gzreader_initialize): revert a part of r33937.

Browse source 
1st, to change the mode of an IO is very sensitive problem, so
  the maintainer of this library should judge it.
  2nd, usually Zlib::GzReader.new is not called directly.  #initialize
  is called via .open, and in the method the I/O is opened in binary
  mode, so there is no problem without changing the mode in #initialize.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
usa 2011-12-05 01:25:47 +00:00
parent 7f65469226
commit 8229b9dd3f
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ChangeLog
View file

@ -1,3 +1,12 @@
Mon Dec 5 10:18:45 2011 NAKAMURA Usaku <usa@ruby-lang.org>
* ext/zlib/zlib.c (rb_gzreader_initialize): revert a part of r33937.
1st, to change the mode of an IO is very sensitive problem, so
the maintainer of this library should judge it.
2nd, usually Zlib::GzReader.new is not called directly. #initialize
is called via .open, and in the method the I/O is opened in binary
mode, so there is no problem without changing the mode in #initialize.
Sun Dec 4 22:53:12 2011 Tanaka Akira <akr@fsij.org>
* lib/tempfile.rb: don't use lock directory. [ruby-dev:39197]

8
ext/zlib/zlib.c
View file

@ -10,7 +10,6 @@
#include <zlib.h>
#include <time.h>
#include <ruby/io.h>
#include <fcntl.h>
#ifdef HAVE_VALGRIND_MEMCHECK_H
# include <valgrind/memcheck.h>
@ -3426,13 +3425,6 @@ rb_gzreader_initialize(int argc, VALUE *argv, VALUE obj)
Data_Get_Struct(obj, struct gzfile, gz);
rb_scan_args(argc, argv, "1:", &io, &opt);
#ifdef O_BINARY
if (BUILTIN_TYPE(io) == T_FILE) {
rb_io_t *fptr;
GetOpenFile(io, fptr);
setmode(fptr->fd, O_BINARY);
}
#endif
/* this is undocumented feature of zlib */
err = inflateInit2(&gz->z.stream, -MAX_WBITS);