diff --git a/ChangeLog b/ChangeLog index abe7005a63..69534f618a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Thu Feb 21 13:47:59 2013 KOSAKI Motohiro + + * file.c (rb_group_member): added an error check. SUS says, + getgroups(small_value) may return EINVAL. + Thu Feb 21 13:37:07 2013 KOSAKI Motohiro * file.c (RB_MAX_GROUPS): moved to diff --git a/file.c b/file.c index 1cc7f63d18..69b5a7cf4b 100644 --- a/file.c +++ b/file.c @@ -1036,7 +1036,7 @@ rb_group_member(GETGROUPS_T gid) while (groups <= RB_MAX_GROUPS) { gary = ALLOCV_N(GETGROUPS_T, v, groups); anum = getgroups(groups, gary); - if (anum != groups) + if (anum != -1 && anum != groups) break; groups *= 2; if (v) { @@ -1044,6 +1044,8 @@ rb_group_member(GETGROUPS_T gid) v = 0; } } + if (anum == -1) + return FALSE; while (--anum >= 0) { if (gary[anum] == gid) {