From 8d2333019abb1f8ad882dadf9096f81e9f427c6e Mon Sep 17 00:00:00 2001 From: Masataka Pocke Kuwabara Date: Sat, 11 Jul 2020 16:01:05 +0900 Subject: [PATCH] Fix MonitorMixin when the super's initialize has kwargs --- ext/monitor/lib/monitor.rb | 2 +- test/monitor/test_monitor.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/ext/monitor/lib/monitor.rb b/ext/monitor/lib/monitor.rb index 63a54fe731..08a3a31ef0 100644 --- a/ext/monitor/lib/monitor.rb +++ b/ext/monitor/lib/monitor.rb @@ -220,7 +220,7 @@ module MonitorMixin # Use extend MonitorMixin or include MonitorMixin instead # of this constructor. Have look at the examples above to understand how to # use this module. - def initialize(*args) + def initialize(...) super mon_initialize end diff --git a/test/monitor/test_monitor.rb b/test/monitor/test_monitor.rb index 721c848d68..734b639d4c 100644 --- a/test/monitor/test_monitor.rb +++ b/test/monitor/test_monitor.rb @@ -236,6 +236,22 @@ class TestMonitor < Test::Unit::TestCase assert NewCondTest.new.cond.instance_variable_get(:@monitor) != nil end + class KeywordInitializeParent + def initialize(x:) + end + end + + class KeywordInitializeChild < KeywordInitializeParent + include MonitorMixin + def initialize + super(x: 1) + end + end + + def test_initialize_with_keyword_arg + assert KeywordInitializeChild.new + end + def test_timedwait cond = @monitor.new_cond b = "foo"