kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

test/ruby/test_io.rb (test_recycled_fd_close): remove hacks

Browse source 
I think I finally fixed the underlying bug in r65937
("io.c (fptr_finalize_flush): close race leading to EBADF")

I've run this test over 100000 times on a multicore system, now.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
normal 2018-11-30 11:44:21 +00:00
parent 26771cadc0
commit 8f23f690c1
1 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
test/ruby/test_io.rb
View file

@ -3774,14 +3774,6 @@ __END__
th = Thread.new { r.read(1) } th = Thread.new { r.read(1) }
w.write(dot) w.write(dot)
# XXX not sure why this is needed on Linux, otherwise
# the "good" reader thread doesn't always join properly
# because the reader never sees the first write
if RUBY_PLATFORM =~ /linux/
# assert_equal can fail if this is another char...
w.write(dot)
end
assert_same th, th.join(15), '"good" reader timeout' assert_same th, th.join(15), '"good" reader timeout'
assert_equal(dot, th.value) assert_equal(dot, th.value)
end end
@ -3800,9 +3792,6 @@ __END__
end end
Thread.pass until th.stop? Thread.pass until th.stop?
# XXX not sure why, this reduces Linux CI failures
assert_nil th.join(0.001)
r.close r.close
assert_same th, th.join(30), '"bad" reader timeout' assert_same th, th.join(30), '"bad" reader timeout'
assert_match(/stream closed/, th.value.message) assert_match(/stream closed/, th.value.message)