From 8fd16730f0500c115c6ab60f4decd9c9e4dbc29d Mon Sep 17 00:00:00 2001 From: nobu Date: Wed, 14 Feb 2018 05:11:02 +0000 Subject: [PATCH] mjit.h: compare as pointer * mjit.c (mjit_get_iseq_func), mjit.h (mjit_exec): do not compare a pointer as shorter type. by loosing the precision, different values can result in "equal" wrongly. enum type is an alias of `int`, and is often shorter than a pointer type nowadays. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- mjit.c | 2 +- mjit.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mjit.c b/mjit.c index c993064aea..7bbc30f6c0 100644 --- a/mjit.c +++ b/mjit.c @@ -1123,7 +1123,7 @@ mjit_get_iseq_func(const struct rb_iseq_constant_body *body) struct timeval tv; tv.tv_sec = 0; tv.tv_usec = 1000; - while ((enum rb_mjit_iseq_func)body->jit_func == NOT_READY_JIT_ISEQ_FUNC) { + while (body->jit_func == (mjit_func_t)NOT_READY_JIT_ISEQ_FUNC) { CRITICAL_SECTION_START(3, "in mjit_get_iseq_func for a client wakeup"); rb_native_cond_broadcast(&mjit_worker_wakeup); CRITICAL_SECTION_FINISH(3, "in mjit_get_iseq_func for a client wakeup"); diff --git a/mjit.h b/mjit.h index 1a9f0ec6c7..9bf2a00913 100644 --- a/mjit.h +++ b/mjit.h @@ -103,7 +103,7 @@ mjit_exec(rb_execution_context_t *ec) func = body->jit_func; if (UNLIKELY(mjit_opts.wait && mjit_opts.min_calls == total_calls && mjit_target_iseq_p(body) - && (enum rb_mjit_iseq_func)func == NOT_ADDED_JIT_ISEQ_FUNC)) { + && func == (mjit_func_t)NOT_ADDED_JIT_ISEQ_FUNC)) { mjit_add_iseq_to_process(iseq); func = mjit_get_iseq_func(body); }