mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
Turn class variable warnings into exceptions
This changes the following warnings: * warning: class variable access from toplevel * warning: class variable @foo of D is overtaken by C into RuntimeErrors. Handle defined?(@@foo) at toplevel by returning nil instead of raising an exception (the previous behavior warned before returning nil when defined? was used). Refactor the specs to avoid the warnings even in older versions. The specs were checking for the warnings, but the purpose of the related specs as evidenced from their description is to test for behavior, not for warnings. Fixes [Bug #14541]
This commit is contained in:
parent
defc0ee9d1
commit
900e83b501
Notes:
git
2020-04-10 16:29:30 +09:00
9 changed files with 37 additions and 34 deletions
|
@ -28,10 +28,8 @@ describe "NameError#receiver" do
|
|||
|
||||
it "returns the Object class when an undefined class variable is called" do
|
||||
-> {
|
||||
-> {
|
||||
@@doesnt_exist
|
||||
}.should complain(/class variable access from toplevel/)
|
||||
}.should raise_error(NameError) {|e| e.receiver.should equal(Object) }
|
||||
eval("class singleton_class::A; @@doesnt_exist end", binding, __FILE__, __LINE__)
|
||||
}.should raise_error(NameError) {|e| e.receiver.should equal(singleton_class::A) }
|
||||
end
|
||||
|
||||
it "returns a class when an undefined class variable is called in a subclass' namespace" do
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue