From 93446fedd3ae3efcccdeede1a5af1ec7e8b6d1cd Mon Sep 17 00:00:00 2001 From: nobu Date: Tue, 30 Jun 2015 08:28:28 +0000 Subject: [PATCH] io.c: reopen OS encoding path * io.c (rb_io_reopen): freopen(3) with OS encoding path. [ruby-core:69780] [Bug #11320] * win32/file.c (rb_freopen): wrapper of wchar version freopen(3). use _wfreopen_s() if available. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51069 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 8 ++++++++ configure.in | 1 + io.c | 21 ++++++++++++++++++--- test/ruby/test_io.rb | 20 ++++++++++++++++++++ win32/file.c | 22 ++++++++++++++++++++++ 5 files changed, 69 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2dfafa6cf2..28123d8f7f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +Tue Jun 30 17:28:25 2015 Nobuyoshi Nakada + + * io.c (rb_io_reopen): freopen(3) with OS encoding path. + [ruby-core:69780] [Bug #11320] + + * win32/file.c (rb_freopen): wrapper of wchar version freopen(3). + use _wfreopen_s() if available. + Tue Jun 30 08:24:08 2015 Eric Wong * io.c (rb_io_oflags_modestr): handle O_TRUNC correctly diff --git a/configure.in b/configure.in index 79b410e86f..04767d07fd 100644 --- a/configure.in +++ b/configure.in @@ -1130,6 +1130,7 @@ main() AC_DEFINE(HAVE_TYPE_NET_LUID, 1) fi AC_CHECK_FUNCS(_gmtime64_s) + AC_CHECK_FUNCS(_wfreopen_s) AC_LIBOBJ([langinfo]) ], [os2-emx*], [ LIBS="-lm $LIBS" diff --git a/io.c b/io.c index 8358c74ff9..40d8920081 100644 --- a/io.c +++ b/io.c @@ -6706,6 +6706,20 @@ io_reopen(VALUE io, VALUE nfile) return io; } +#ifdef _WIN32 +int rb_freopen(VALUE fname, const char *mode, FILE *fp); +#else +static int +rb_freopen(VALUE fname, const char *mode, FILE *fp) +{ + if (!freopen(RSTRING_PTR(fname), mode, fp)) { + RB_GC_GUARD(fname); + return errno; + } + return 0; +} +#endif + /* * call-seq: * ios.reopen(other_IO) -> ios @@ -6777,9 +6791,10 @@ rb_io_reopen(int argc, VALUE *argv, VALUE file) fptr->rbuf.off = fptr->rbuf.len = 0; if (fptr->stdio_file) { - if (freopen(RSTRING_PTR(fptr->pathv), rb_io_oflags_modestr(oflags), fptr->stdio_file) == 0) { - rb_sys_fail_path(fptr->pathv); - } + int e = rb_freopen(rb_str_encode_ospath(fptr->pathv), + rb_io_oflags_modestr(oflags), + fptr->stdio_file); + if (e) rb_syserr_fail_path(e, fptr->pathv); fptr->fd = fileno(fptr->stdio_file); rb_fd_fix_cloexec(fptr->fd); #ifdef USE_SETVBUF diff --git a/test/ruby/test_io.rb b/test/ruby/test_io.rb index 8e09df48f5..51b67f37f5 100644 --- a/test/ruby/test_io.rb +++ b/test/ruby/test_io.rb @@ -2164,6 +2164,26 @@ End } end + bug11320 = '[ruby-core:69780] [Bug #11320]' + ["UTF-8", "EUC-JP", "Shift_JIS"].each do |enc| + define_method("test_reopen_nonascii(#{enc})") do + mkcdtmpdir do + fname = "\u{30eb 30d3 30fc}".encode(enc) + File.write(fname, '') + assert_file.exist?(fname) + stdin = $stdin.dup + begin + assert_nothing_raised(Errno::ENOENT, enc) { + $stdin.reopen(fname, 'r') + } + ensure + $stdin.reopen(stdin) + stdin.close + end + end + end + end + def test_foreach a = [] IO.foreach("|" + EnvUtil.rubybin + " -e 'puts :foo; puts :bar; puts :baz'") {|x| a << x } diff --git a/win32/file.c b/win32/file.c index 4a31fe37eb..799810a4ef 100644 --- a/win32/file.c +++ b/win32/file.c @@ -721,6 +721,28 @@ rb_file_load_ok(const char *path) return ret; } +int +rb_freopen(VALUE fname, const char *mode, FILE *file) +{ + WCHAR *wname, wmode[4]; + int e = 0, n = MultiByteToWideChar(CP_ACP, 0, mode, -1, NULL, 0); + if (n > numberof(wmode)) return EINVAL; + MultiByteToWideChar(CP_ACP, 0, mode, -1, wmode, numberof(wmode)); + wname = rb_w32_mbstr_to_wstr(CP_UTF8, RSTRING_PTR(fname), + rb_long2int(RSTRING_LEN(fname)), NULL); + RB_GC_GUARD(fname); +#if RUBY_MSVCRT_VERSION < 80 && !defined(HAVE__WFREOPEN_S) + e = _wfreopen(wname, wmode, file) ? 0 : errno; +#else + { + FILE *newfp = 0; + e = _wfreopen_s(&newfp, wname, wmode, file); + } +#endif + xfree(wname); + return e; +} + void Init_w32_codepage(void) {