mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
[rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/
The `rails_fail` name is misleading because there's no specific reason
why such a gem would need to fail. As a matter of fact, `bundle
install`'ing a Genfile with only that dependency like the spec the
previous commit adds is not expected to fail.
b947f40701
This commit is contained in:
parent
f8f3f11ed5
commit
94fc709dd1
Notes:
git
2020-06-18 19:15:24 +09:00
3 changed files with 8 additions and 8 deletions
|
@ -78,13 +78,13 @@ RSpec.describe "bundle check" do
|
|||
G
|
||||
install_gemfile <<-G
|
||||
source "#{file_uri_for(gem_repo1)}"
|
||||
gem 'rails_fail'
|
||||
gem 'rails_pinned_to_old_activesupport'
|
||||
G
|
||||
|
||||
gemfile <<-G
|
||||
source "#{file_uri_for(gem_repo1)}"
|
||||
gem "rails"
|
||||
gem "rails_fail"
|
||||
gem "rails_pinned_to_old_activesupport"
|
||||
G
|
||||
|
||||
bundle :check
|
||||
|
|
|
@ -96,7 +96,7 @@ RSpec.describe "bundle install" do
|
|||
install_gemfile <<-G
|
||||
source "#{file_uri_for(gem_repo2)}"
|
||||
gem "activemerchant"
|
||||
gem "rails_fail"
|
||||
gem "rails_pinned_to_old_activesupport"
|
||||
G
|
||||
|
||||
nice_error = <<-E.strip.gsub(/^ {8}/, "")
|
||||
|
@ -105,7 +105,7 @@ RSpec.describe "bundle install" do
|
|||
activemerchant was resolved to 1.0, which depends on
|
||||
activesupport (>= 2.0.0)
|
||||
|
||||
rails_fail was resolved to 1.0, which depends on
|
||||
rails_pinned_to_old_activesupport was resolved to 1.0, which depends on
|
||||
activesupport (= 1.2.3)
|
||||
E
|
||||
expect(err).to include(nice_error)
|
||||
|
@ -116,7 +116,7 @@ RSpec.describe "bundle install" do
|
|||
|
||||
install_gemfile <<-G
|
||||
source "#{file_uri_for(gem_repo2)}"
|
||||
gem "rails_fail"
|
||||
gem "rails_pinned_to_old_activesupport"
|
||||
gem "activesupport", "2.3.5"
|
||||
G
|
||||
|
||||
|
@ -125,7 +125,7 @@ RSpec.describe "bundle install" do
|
|||
In Gemfile:
|
||||
activesupport (= 2.3.5)
|
||||
|
||||
rails_fail was resolved to 1.0, which depends on
|
||||
rails_pinned_to_old_activesupport was resolved to 1.0, which depends on
|
||||
activesupport (= 1.2.3)
|
||||
E
|
||||
expect(err).to include(nice_error)
|
||||
|
@ -139,7 +139,7 @@ RSpec.describe "bundle install" do
|
|||
|
||||
install_gemfile <<-G
|
||||
source "#{file_uri_for(gem_repo2)}"
|
||||
gem "rails_fail"
|
||||
gem "rails_pinned_to_old_activesupport"
|
||||
G
|
||||
|
||||
expect(out).to include("Installing activesupport 1.2.3 (was 2.3.2)")
|
||||
|
|
|
@ -76,7 +76,7 @@ module Spec
|
|||
s.add_dependency "activesupport", ">= 2.0.0"
|
||||
end
|
||||
|
||||
build_gem "rails_fail" do |s|
|
||||
build_gem "rails_pinned_to_old_activesupport" do |s|
|
||||
s.add_dependency "activesupport", "= 1.2.3"
|
||||
end
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue