kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/

Browse source 
The `rails_fail` name is misleading because there's no specific reason
why such a gem would need to fail. As a matter of fact, `bundle
install`'ing a Genfile with only that dependency like the spec the
previous commit adds is not expected to fail.

b947f40701
This commit is contained in:
David Rodríguez 2020-06-07 13:23:10 +02:00 • committed by Hiroshi SHIBATA
parent f8f3f11ed5
commit 94fc709dd1
Notes: git 2020-06-18 19:15:24 +09:00
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec/bundler/commands/check_spec.rb
View file

@ -78,13 +78,13 @@ RSpec.describe "bundle check" do
G G
install_gemfile <<-G install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}" source "#{file_uri_for(gem_repo1)}"
gem 'rails_fail' gem 'rails_pinned_to_old_activesupport'
G G
gemfile <<-G gemfile <<-G
source "#{file_uri_for(gem_repo1)}" source "#{file_uri_for(gem_repo1)}"
gem "rails" gem "rails"
gem "rails_fail" gem "rails_pinned_to_old_activesupport"
G G
bundle :check bundle :check

10
spec/bundler/install/bundler_spec.rb
View file

@ -96,7 +96,7 @@ RSpec.describe "bundle install" do
install_gemfile <<-G install_gemfile <<-G
source "#{file_uri_for(gem_repo2)}" source "#{file_uri_for(gem_repo2)}"
gem "activemerchant" gem "activemerchant"
gem "rails_fail" gem "rails_pinned_to_old_activesupport"
G G
nice_error = <<-E.strip.gsub(/^ {8}/, "") nice_error = <<-E.strip.gsub(/^ {8}/, "")
@ -105,7 +105,7 @@ RSpec.describe "bundle install" do
activemerchant was resolved to 1.0, which depends on activemerchant was resolved to 1.0, which depends on
activesupport (>= 2.0.0) activesupport (>= 2.0.0)
rails_fail was resolved to 1.0, which depends on rails_pinned_to_old_activesupport was resolved to 1.0, which depends on
activesupport (= 1.2.3) activesupport (= 1.2.3)
E E
expect(err).to include(nice_error) expect(err).to include(nice_error)
@ -116,7 +116,7 @@ RSpec.describe "bundle install" do
install_gemfile <<-G install_gemfile <<-G
source "#{file_uri_for(gem_repo2)}" source "#{file_uri_for(gem_repo2)}"
gem "rails_fail" gem "rails_pinned_to_old_activesupport"
gem "activesupport", "2.3.5" gem "activesupport", "2.3.5"
G G
@ -125,7 +125,7 @@ RSpec.describe "bundle install" do
In Gemfile: In Gemfile:
activesupport (= 2.3.5) activesupport (= 2.3.5)
rails_fail was resolved to 1.0, which depends on rails_pinned_to_old_activesupport was resolved to 1.0, which depends on
activesupport (= 1.2.3) activesupport (= 1.2.3)
E E
expect(err).to include(nice_error) expect(err).to include(nice_error)
@ -139,7 +139,7 @@ RSpec.describe "bundle install" do
install_gemfile <<-G install_gemfile <<-G
source "#{file_uri_for(gem_repo2)}" source "#{file_uri_for(gem_repo2)}"
gem "rails_fail" gem "rails_pinned_to_old_activesupport"
G G
expect(out).to include("Installing activesupport 1.2.3 (was 2.3.2)") expect(out).to include("Installing activesupport 1.2.3 (was 2.3.2)")

2
spec/bundler/support/builders.rb
View file

@ -76,7 +76,7 @@ module Spec
s.add_dependency "activesupport", ">= 2.0.0" s.add_dependency "activesupport", ">= 2.0.0"
end end
build_gem "rails_fail" do |s| build_gem "rails_pinned_to_old_activesupport" do |s|
s.add_dependency "activesupport", "= 1.2.3" s.add_dependency "activesupport", "= 1.2.3"
end end