From 9849555a3e6cd2e088ec08c0560975208b4d0ec4 Mon Sep 17 00:00:00 2001 From: nobu Date: Wed, 2 Dec 2015 00:55:50 +0000 Subject: [PATCH] explicit_bzero.c: fix comments * missing/explicit_bzero.c: fix comments. Microsoft Visual Studio does not provide memset_s() in 12.0 at least. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- missing/explicit_bzero.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/missing/explicit_bzero.c b/missing/explicit_bzero.c index bf493c18ac..db66eeeb9d 100644 --- a/missing/explicit_bzero.c +++ b/missing/explicit_bzero.c @@ -5,17 +5,18 @@ #include #endif -/* Similar to bzero(), but have a guarantee not to be eliminated from compiler +/* Similar to bzero(), but has a guarantee not to be eliminated from compiler optimization. */ /* OS support note: - * BSD have explicit_bzero(). - * Windows, OS-X have memset_s(). + * BSDs have explicit_bzero(). + * OS-X has memset_s(). + * Windows has SecureZeroMemory() since XP. * Linux has none. *Sigh* */ /* - * Following URL explain why memset_s is added to the standard. + * Following URL explains why memset_s is added to the standard. * http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1381.pdf */ @@ -40,7 +41,7 @@ explicit_bzero(void *b, size_t len) #elif defined HAVE_FUNC_WEAK -/* A weak function never be optimization away. Even if nobody use it. */ +/* A weak function never be optimized away. Even if nobody uses it. */ WEAK(void ruby_explicit_bzero_hook_unused(void *buf, size_t len)); void ruby_explicit_bzero_hook_unused(void *buf, size_t len) @@ -64,8 +65,8 @@ explicit_bzero(void *b, size_t len) { /* * volatile is not enough if compiler have a LTO (link time - * optimization). At least, the standard provide no guarantee. - * However, gcc and major other compiler never optimization a volatile + * optimization). At least, the standard provides no guarantee. + * However, gcc and major other compiler never optimize a volatile * variable away. So, using volatile is practically ok. */ volatile char* p = (volatile char*)b;