kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

bidecimal: improve tests' independence (#3297)

Browse source 
Tests depending on the rounding mode must specify the appropriate rounding
mode and restore to the original mode at the end.
This commit is contained in:
Kenta Murata 2020-07-12 17:30:29 +09:00 • committed by GitHub
parent 3b96ad9b54
commit 9b433d34da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: git 2020-07-12 17:31:05 +09:00 
Merged-By: mrkn <mrkn@ruby-lang.org>
2 changed files with 15 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/bigdecimal/test_bigdecimal.rb
View file

@ -334,6 +334,8 @@ class TestBigDecimal < Test::Unit::TestCase
end end
def test_save_rounding_mode def test_save_rounding_mode
saved_mode = BigDecimal.mode(BigDecimal::ROUND_MODE)
BigDecimal.mode(BigDecimal::ROUND_MODE, BigDecimal::ROUND_FLOOR) BigDecimal.mode(BigDecimal::ROUND_MODE, BigDecimal::ROUND_FLOOR)
BigDecimal.save_rounding_mode do BigDecimal.save_rounding_mode do
BigDecimal.mode(BigDecimal::ROUND_MODE, BigDecimal::ROUND_HALF_EVEN) BigDecimal.mode(BigDecimal::ROUND_MODE, BigDecimal::ROUND_HALF_EVEN)
@ -341,6 +343,8 @@ class TestBigDecimal < Test::Unit::TestCase
assert_equal(BigDecimal::ROUND_FLOOR, BigDecimal.mode(BigDecimal::ROUND_MODE)) assert_equal(BigDecimal::ROUND_FLOOR, BigDecimal.mode(BigDecimal::ROUND_MODE))
assert_equal(42, BigDecimal.save_rounding_mode { 42 }) assert_equal(42, BigDecimal.save_rounding_mode { 42 })
ensure
BigDecimal.mode(BigDecimal::ROUND_MODE, saved_mode)
end end
def test_save_limit def test_save_limit

18
test/bigdecimal/test_bigdecimal_util.rb
View file

@ -61,15 +61,19 @@ class TestBigDecimalUtil < Test::Unit::TestCase
end end
def test_Complex_to_d def test_Complex_to_d
assert_equal(BigDecimal("1"), Complex(1, 0).to_d) BigDecimal.save_rounding_mode do
assert_equal(BigDecimal("0.333333333333333333333"), BigDecimal.mode(BigDecimal::ROUND_MODE, BigDecimal::ROUND_HALF_EVEN)
Complex(1.quo(3), 0).to_d(21))
assert_equal(BigDecimal("0.1234567"), Complex(0.1234567, 0).to_d)
assert_equal(BigDecimal("0.1235"), Complex(0.1234567, 0).to_d(4))
assert_raise_with_message(ArgumentError, "can't omit precision for a Rational.") { Complex(1.quo(3), 0).to_d } assert_equal(BigDecimal("1"), Complex(1, 0).to_d)
assert_equal(BigDecimal("0.333333333333333333333"),
Complex(1.quo(3), 0).to_d(21))
assert_equal(BigDecimal("0.1234567"), Complex(0.1234567, 0).to_d)
assert_equal(BigDecimal("0.1235"), Complex(0.1234567, 0).to_d(4))
assert_raise_with_message(ArgumentError, "Unable to make a BigDecimal from non-zero imaginary number") { Complex(1, 1).to_d } assert_raise_with_message(ArgumentError, "can't omit precision for a Rational.") { Complex(1.quo(3), 0).to_d }
assert_raise_with_message(ArgumentError, "Unable to make a BigDecimal from non-zero imaginary number") { Complex(1, 1).to_d }
end
end end
def test_String_to_d def test_String_to_d