From 9b55a9649fb1973180559a067cfee0d6f234fef8 Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada Date: Mon, 27 Jan 2020 10:10:58 +0900 Subject: [PATCH] Removed useless "spec"s It is not specific to particular methods that keyword option arguments are coerced to `Hash`es using `to_hash` method. --- spec/ruby/core/array/sample_spec.rb | 20 -------------------- spec/ruby/core/array/shuffle_spec.rb | 9 --------- 2 files changed, 29 deletions(-) diff --git a/spec/ruby/core/array/sample_spec.rb b/spec/ruby/core/array/sample_spec.rb index 87f81999f4..73b6bdf480 100644 --- a/spec/ruby/core/array/sample_spec.rb +++ b/spec/ruby/core/array/sample_spec.rb @@ -65,26 +65,6 @@ describe "Array#sample" do end describe "with options" do - ruby_version_is ""..."2.8" do - # keyword argument since 2.8 - it "calls #to_hash to convert the passed Object" do - obj = mock("array_sample") - obj.should_receive(:to_hash).and_return({}) - obj.should_not_receive(:to_int) - - [1, 2].sample(obj).should be_an_instance_of(Fixnum) - end - - it "calls #to_int on the first argument and #to_hash on the second when passed Objects" do - count = mock("array_sample_count") - count.should_receive(:to_int).and_return(2) - options = mock("array_sample_options") - options.should_receive(:to_hash).and_return({}) - - [1, 2].sample(count, options).size.should == 2 - end - end - it "calls #rand on the Object passed by the :random key in the arguments Hash" do obj = mock("array_sample_random") obj.should_receive(:rand).and_return(0.5) diff --git a/spec/ruby/core/array/shuffle_spec.rb b/spec/ruby/core/array/shuffle_spec.rb index 106ef05ce2..857062c4c9 100644 --- a/spec/ruby/core/array/shuffle_spec.rb +++ b/spec/ruby/core/array/shuffle_spec.rb @@ -25,15 +25,6 @@ describe "Array#shuffle" do ArraySpecs::MyArray[1, 2, 3].shuffle.should be_an_instance_of(Array) end - ruby_version_is ""..."2.8" do - # keyword argument since 2.8 - it "attempts coercion via #to_hash" do - obj = mock('hash') - obj.should_receive(:to_hash).once.and_return({}) - [2, 3].shuffle(obj) - end - end - it "calls #rand on the Object passed by the :random key in the arguments Hash" do obj = mock("array_shuffle_random") obj.should_receive(:rand).at_least(1).times.and_return(0.5)