From 9e92292e307fcdb3ef8e44f942135116de6616cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=9C=E9=83=A8=E6=98=8C=E5=B9=B3?=
 <shyouhei@ruby-lang.org>
Date: Mon, 15 Jun 2020 15:26:31 +0900
Subject: [PATCH] rb_io_modestr_fmode: do not goto into a branch

I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
---
 io.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/io.c b/io.c
index 3e0ada4f1a..36099d89ad 100644
--- a/io.c
+++ b/io.c
@@ -5541,8 +5541,7 @@ rb_io_modestr_fmode(const char *modestr)
 	fmode |= FMODE_WRITABLE | FMODE_APPEND | FMODE_CREATE;
 	break;
       default:
-      error:
-	rb_raise(rb_eArgError, "invalid access mode %s", modestr);
+        goto error;
     }
 
     while (*m) {
@@ -5576,6 +5575,9 @@ rb_io_modestr_fmode(const char *modestr)
         goto error;
 
     return fmode;
+
+  error:
+    rb_raise(rb_eArgError, "invalid access mode %s", modestr);
 }
 
 int