mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
* error.c (exc_to_s, name_err_to_s, name_err_mesg_to_str): do not
taint messages. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@37068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
parent
a63bde6d91
commit
a1ed68b931
3 changed files with 56 additions and 7 deletions
|
@ -451,4 +451,54 @@ end.join
|
|||
end
|
||||
end
|
||||
end
|
||||
|
||||
def test_to_s_taintness_propagation
|
||||
for exc in [Exception, NameError]
|
||||
m = "abcdefg"
|
||||
e = exc.new(m)
|
||||
e.taint
|
||||
s = e.to_s
|
||||
assert_equal(false, m.tainted?,
|
||||
"#{exc}#to_s should not propagate taintness")
|
||||
assert_equal(false, s.tainted?,
|
||||
"#{exc}#to_s should not propagate taintness")
|
||||
end
|
||||
|
||||
o = Object.new
|
||||
def o.to_str
|
||||
"foo"
|
||||
end
|
||||
o.taint
|
||||
e = NameError.new(o)
|
||||
s = e.to_s
|
||||
assert_equal(false, s.tainted?)
|
||||
end
|
||||
|
||||
def test_exception_to_s_should_not_propagate_untrustedness
|
||||
favorite_lang = "Ruby"
|
||||
|
||||
for exc in [Exception, NameError]
|
||||
assert_raise(SecurityError) do
|
||||
lambda {
|
||||
$SAFE = 4
|
||||
exc.new(favorite_lang).to_s
|
||||
favorite_lang.replace("Python")
|
||||
}.call
|
||||
end
|
||||
end
|
||||
|
||||
assert_raise(SecurityError) do
|
||||
lambda {
|
||||
$SAFE = 4
|
||||
o = Object.new
|
||||
o.singleton_class.send(:define_method, :to_str) {
|
||||
favorite_lang
|
||||
}
|
||||
NameError.new(o).to_s
|
||||
favorite_lang.replace("Python")
|
||||
}.call
|
||||
end
|
||||
|
||||
assert_equal("Ruby", favorite_lang)
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue