From a50ef07e16b8d09073c34ba3124868b22917972f Mon Sep 17 00:00:00 2001 From: matz Date: Tue, 25 Sep 2007 12:41:48 +0000 Subject: [PATCH] * eval_method.ci (remove_method): should not remove undef place holder. [ruby-dev:31816], [ruby-dev:31817] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@13511 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 5 +++++ eval_method.ci | 10 ++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c5316ba256..8e0537d344 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +Tue Sep 25 13:43:03 2007 Yukihiro Matsumoto + + * eval_method.ci (remove_method): should not remove undef place + holder. [ruby-dev:31816], [ruby-dev:31817] + Tue Sep 25 09:51:31 2007 Yukihiro Matsumoto * eval.c (rb_longjmp): source file information may be NULL. diff --git a/eval_method.ci b/eval_method.ci index a647335ed6..5dfcdfacb6 100644 --- a/eval_method.ci +++ b/eval_method.ci @@ -305,8 +305,14 @@ remove_method(VALUE klass, ID mid) if (mid == object_id || mid == __send || mid == __send_bang || mid == init) { rb_warn("removing `%s' may cause serious problem", rb_id2name(mid)); } - if (!st_delete(RCLASS(klass)->m_tbl, &mid, &data) || - !(body = (NODE *)data) || !body->nd_body) { + if (st_lookup(RCLASS(klass)->m_tbl, mid, &data)) { + body = (NODE *)data; + if (!body || !body->nd_body) body = 0; + else { + st_delete(RCLASS(klass)->m_tbl, &mid, &data); + } + } + if (!body) { rb_name_error(mid, "method `%s' not defined in %s", rb_id2name(mid), rb_class2name(klass)); }