mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
[bundler/bundler] Fix rake release
not prompting for OTP code
Co-authored-by: Colby Swandale <me@colby.fyi>
Co-authored-by: Kevin Deisz <kevin.deisz@gmail.com>
1b2bbc7364
This commit is contained in:
parent
51bdc9433b
commit
a685a8643f
2 changed files with 15 additions and 2 deletions
|
@ -106,7 +106,7 @@ module Bundler
|
|||
unless allowed_push_host || Bundler.user_home.join(".gem/credentials").file?
|
||||
raise "Your rubygems.org credentials aren't set. Run `gem push` to set them."
|
||||
end
|
||||
sh(gem_command)
|
||||
sh_with_input(gem_command)
|
||||
Bundler.ui.confirm "Pushed #{name} #{version} to #{gem_push_host}"
|
||||
end
|
||||
|
||||
|
@ -180,6 +180,13 @@ module Bundler
|
|||
gemspec.name
|
||||
end
|
||||
|
||||
def sh_with_input(cmd)
|
||||
Bundler.ui.debug(cmd)
|
||||
SharedHelpers.chdir(base) do
|
||||
abort unless Kernel.system(*cmd)
|
||||
end
|
||||
end
|
||||
|
||||
def sh(cmd, &block)
|
||||
out, status = sh_with_status(cmd, &block)
|
||||
unless status.success?
|
||||
|
|
|
@ -233,6 +233,12 @@ RSpec.describe Bundler::GemHelper do
|
|||
|
||||
Rake.application["release"].invoke
|
||||
end
|
||||
|
||||
it "uses Kernel.system" do
|
||||
expect(Kernel).to receive(:system).with("gem", "push", app_gem_path.to_s, "--host", "http://example.org").and_return(true)
|
||||
|
||||
Rake.application["release"].invoke
|
||||
end
|
||||
end
|
||||
|
||||
it "even if tag already exists" do
|
||||
|
@ -255,7 +261,7 @@ RSpec.describe Bundler::GemHelper do
|
|||
before(:each) do
|
||||
Rake.application = Rake::Application.new
|
||||
subject.install
|
||||
allow(subject).to receive(:sh)
|
||||
allow(subject).to receive(:sh_with_input)
|
||||
end
|
||||
|
||||
after(:each) do
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue