kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

[ruby/io-console] Mark all tests that use run_pty as pend on JRuby

Browse source 
JRuby's PTY.spawn does not produce a process with its own
controlling terminal, which is necessary for testing these raw
escape sequences. This commit marks those tests as pending.

The functionality tested appears to work at a command line, but
due to this PTY bug in JRuby we cannot test it this way.

See https://github.com/jruby/jruby/issues/6552

a486b72e5e
b5c8e7bfd8
This commit is contained in:
Charles Oliver Nutter 2021-02-04 15:03:45 -06:00 • committed by Nobuyoshi Nakada
parent a1cc044ea1
commit abf71864a5
No known key found for this signature in database
GPG key ID: 7CD2805BFA3770C6
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/io/console/test_io_console.rb
View file

@ -323,8 +323,6 @@ defined?(PTY) and defined?(IO.console) and TestIO_Console.class_eval do
end end
def test_cursor_position def test_cursor_position
return if RUBY_ENGINE == 'jruby'
run_pty("#{<<~"begin;"}\n#{<<~'end;'}") do |r, w, _| run_pty("#{<<~"begin;"}\n#{<<~'end;'}") do |r, w, _|
begin; begin;
con = IO.console con = IO.console
@ -421,6 +419,8 @@ defined?(PTY) and defined?(IO.console) and TestIO_Console.class_eval do
end end
def run_pty(src, n = 1) def run_pty(src, n = 1)
pend("PTY.spawn cannot control terminal on JRuby") if RUBY_ENGINE == 'jruby'
r, w, pid = PTY.spawn(EnvUtil.rubybin, "-I#{TestIO_Console::PATHS.join(File::PATH_SEPARATOR)}", "-rio/console", "-e", src) r, w, pid = PTY.spawn(EnvUtil.rubybin, "-I#{TestIO_Console::PATHS.join(File::PATH_SEPARATOR)}", "-rio/console", "-e", src)
rescue RuntimeError rescue RuntimeError
omit $! omit $!