kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

Replace Gem::Util.silent_system with better tools

Browse source
This commit is contained in:
David Rodríguez 2020-03-24 12:54:22 +01:00 committed by Hiroshi SHIBATA
parent c61031d6b6
commit afce7eb39e
Notes: git 2020-06-15 21:21:03 +09:00 
Merged: https://github.com/ruby/ruby/pull/3229
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/rubygems/source/git.rb
View file

@ -103,9 +103,11 @@ class Gem::Source::Git < Gem::Source
success = system @git, 'reset', '--quiet', '--hard', rev_parse
success &&=
Gem::Util.silent_system @git, 'submodule', 'update',
'--quiet', '--init', '--recursive' if @need_submodules
if @need_submodules
_, status = Open3.capture2e(@git, 'submodule', 'update', '--quiet', '--init', '--recursive')
success &&= status.success?
end
success
end

5
test/rubygems/test_gem_source_git.rb
View file

@ -69,8 +69,9 @@ class TestGemSourceGit < Gem::TestCase
git_gem 'b'
Dir.chdir 'git/a' do
Gem::Util.silent_system @git, 'submodule', '--quiet',
'add', File.expand_path('../b'), 'b'
output, status = Open3.capture2e(@git, 'submodule', '--quiet', 'add', File.expand_path('../b'), 'b')
assert status.success?, output
system @git, 'commit', '--quiet', '-m', 'add submodule b'
end