From b1541606a28872327716243a5b31706c0c2e3c22 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Sun, 5 Apr 2020 13:42:08 +0200 Subject: [PATCH] [rubygems/rubygems] Fix incorrect `gem uninstall --all` message Currently `gem uninstall --all` shows the following incorrect message after completion: ``` INFO: Uninstalled all gems in ``` Now it shows something that actually makes sense like: ``` INFO: Uninstalled all gems in /home/deivid/Code/rubygems/tmp/test_rubygems_6986/gemhome ``` https://github.com/rubygems/rubygems/commit/8fa05e8f8c --- lib/rubygems/commands/uninstall_command.rb | 2 +- test/rubygems/test_gem_commands_uninstall_command.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/rubygems/commands/uninstall_command.rb b/lib/rubygems/commands/uninstall_command.rb index 68e048c010..c1a9dbba32 100644 --- a/lib/rubygems/commands/uninstall_command.rb +++ b/lib/rubygems/commands/uninstall_command.rb @@ -143,7 +143,7 @@ that is a dependency of an existing gem. You can use the uninstall_gem spec.name end - alert "Uninstalled all gems in #{options[:install_dir]}" + alert "Uninstalled all gems in #{options[:install_dir] || Gem.dir}" end def uninstall_specific diff --git a/test/rubygems/test_gem_commands_uninstall_command.rb b/test/rubygems/test_gem_commands_uninstall_command.rb index 1f71b4ce1d..ee63847c84 100644 --- a/test/rubygems/test_gem_commands_uninstall_command.rb +++ b/test/rubygems/test_gem_commands_uninstall_command.rb @@ -361,6 +361,7 @@ class TestGemCommandsUninstallCommand < Gem::InstallerTestCase end assert_equal %w[default-1], Gem::Specification.all_names.sort + assert_equal "INFO: Uninstalled all gems in #{@gemhome}", @ui.output.split("\n").last end def test_execute_outside_gem_home