kotovalexarian-likes-github/ruby--ruby
1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
Code Releases Activity

lib/ostruct.rb: Use FrozenError instead of RuntimeError.

Browse source 
Patch by Yuuji Yaginuma. [Fixes GH-1808]

In other classes, `FrozenError` will be raised if change the frozen
object.
In order to match the behavior, I think that `FrozenError` should
use in `OpenStruct`.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This commit is contained in:
marcandre 2018-02-06 23:52:30 +00:00
parent d3513d313e
commit b16eaf8632
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ostruct.rb
View file

@ -156,7 +156,7 @@ class OpenStruct
begin
@modifiable = true
rescue
raise RuntimeError, "can't modify frozen #{self.class}", caller(3)
raise FrozenError, "can't modify frozen #{self.class}", caller(3)
end
@table
end

6
test/ostruct/test_ostruct.rb
View file

@ -66,15 +66,15 @@ class TC_OpenStruct < Test::Unit::TestCase
o = OpenStruct.new(foo: 42)
o.a = 'a'
o.freeze
assert_raise(RuntimeError) {o.b = 'b'}
assert_raise(FrozenError) {o.b = 'b'}
assert_not_respond_to(o, :b)
assert_raise(RuntimeError) {o.a = 'z'}
assert_raise(FrozenError) {o.a = 'z'}
assert_equal('a', o.a)
assert_equal(42, o.foo)
o = OpenStruct.new :a => 42
def o.frozen?; nil end
o.freeze
assert_raise(RuntimeError, '[ruby-core:22559]') {o.a = 1764}
assert_raise(FrozenError, '[ruby-core:22559]') {o.a = 1764}
end
def test_delete_field