From b2056425185525afc30c4a8f97dff0229642107d Mon Sep 17 00:00:00 2001 From: normal Date: Wed, 11 Jul 2018 08:49:23 +0000 Subject: [PATCH] thread_pthread: avoid redundant error message on pipe2() fail Seeing one error for pipe creation is enough. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- thread_pthread.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/thread_pthread.c b/thread_pthread.c index 29507a370c..3f0ec2e6cc 100644 --- a/thread_pthread.c +++ b/thread_pthread.c @@ -1335,7 +1335,7 @@ setup_communication_pipe_internal(int pipes[2]) err = rb_cloexec_pipe(pipes); if (err != 0) { - rb_warn("Failed to create communication pipe for timer thread: %s", + rb_warn("pipe creation failed for timer: %s, scheduling broken", strerror(errno)); return -1; } @@ -1593,11 +1593,7 @@ rb_thread_create_timer_thread(void) #if TIMER_IMPL == TIMER_THREAD_SLEEPY err = setup_communication_pipe(); - if (err != 0) { - rb_warn("pipe creation failed for timer: %s, scheduling broken", - strerror(err)); - return; - } + if (err) return; #endif /* TIMER_THREAD_SLEEPY */ /* create timer thread */